Skip to content

HGrid.Col.Name.showExpander() not refreshing in all situations #94

Description

@brianjgeiger

There are a few issues in CenterForOpenScience/osf.io#726 that seem to be because I have a showExpander function that returns the correct value but the view isn't being updated all the time.

The specific items from the original are:
There are a number of cases when one would expect the ± button to be hidden when it is shown and vice-versa. Here's what I've found:

  • A project dragged from "All my projects" into a folder that previous had no children will not cause the ± button to appear, although it should. This occurs in any case that doesn't cause the parent folder to refresh.
  • The final project being deleted from a folder will not cause the ± button to disappear on that folder, although it should.
  • In some cases with an unknown cause, a folder will continue to have a ± regardless of what happens to it. This may be related to the smart-folder issue.

This may not have been the original cause in all cases, but I am maintaining a separate "childrenCount" now (so we know whether to show the disclosure control for a folder that isn't already lazy-loaded), and I'm updating it under circumstances when the HGrid wouldn't necessarily know that things have changed.

The only way I can force things to work is to reload the folder above the folder with the control that isn't updating.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions