Summary
go-custom.md CR-001 requires testify (assert/require) for all tests. 36 of 41 test files in the repo already use testify. Five files use raw stdlib t.Errorf/t.Fatalf exclusively:
internal/doctor/doctor_test.go (40+ test functions — the main outlier)internal/complytime/export_test.gointernal/registry/mock_fetcher_test.gopkg/provider/export_test.gopkg/provider/mock_client_test.go
All five files predate the convention pack (go-custom.md was added 2026-05-05 in #494). This is not a regression — it is legacy code that was not migrated when the convention was established.
Action
Migrate these 5 files to use require for fatal preconditions and assert for non-fatal checks, per CR-001 and CR-002.
Convention Reference
Summary
go-custom.mdCR-001 requirestestify(assert/require) for all tests. 36 of 41 test files in the repo already use testify. Five files use raw stdlibt.Errorf/t.Fatalfexclusively:internal/doctor/doctor_test.go(40+ test functions — the main outlier)internal/complytime/export_test.gointernal/registry/mock_fetcher_test.gopkg/provider/export_test.gopkg/provider/mock_client_test.goAll five files predate the convention pack (
go-custom.mdwas added 2026-05-05 in #494). This is not a regression — it is legacy code that was not migrated when the convention was established.Action
Migrate these 5 files to use
requirefor fatal preconditions andassertfor non-fatal checks, per CR-001 and CR-002.Convention Reference
.opencode/uf/packs/go-custom.mdCR-001, CR-002