Upgrade safe dependencies: bcryptjs 3.0.3, @vercel/node 5.x, @types/node 25.x#4
Merged
Merged
Conversation
…ode 25.x - bcryptjs 2.4.3 -> 3.0.3: Ships built-in types, modern ESM, b hashes (backward compatible) - @vercel/node ^3.0.0 -> ^5.7.15: Security fixes for undici, path-to-regexp, tar, esbuild, ajv - @types/node ^20.0.0 -> ^25.6.0: Up-to-date Node.js type definitions - Remove @types/bcryptjs: No longer needed, bcryptjs 3.0 ships its own types Co-Authored-By: Shashvath Puppala <shashvathpuppala.21cmis0265@meruinternationalschool.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Owner
|
@claude, is this dependency update safe? |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades three dependencies that can be safely updated, and removes one that is no longer needed:
bcryptjs$2b$hash default@vercel/node@types/node@types/bcryptjsNot upgraded (intentionally skipped):
mongoose8→9: Extensive breaking changes (driver v7, type overhaul, removednext()in middleware)typescript5→6: Bridge release for TS 7.0 Go rewrite; changes tsconfig defaults with no functional benefit while Vercel's builder still uses TS 5.9.3No source code changes — only
package.jsonandpackage-lock.jsonare modified.Review & Testing Checklist for Human
$2a$password hashes still verify correctly with bcryptjs 3.0. The library claimsbcrypt.compare()handles both$2a$and$2b$prefixes, but this is the highest-risk change — test by logging into an existing account after deploying.@vercel/nodev5 handler API is compatible. TheVercelRequest/VercelResponsetypes are used across all API routes. Deploy a preview and confirm all API endpoints (auth, data save/load, chats, folders) still function.@types/bcryptjswas removed — check thatimport bcrypt from 'bcryptjs'still resolveshash()andcompare()correctly in your IDE/build.$2b$hash generation and the updated@vercel/noderuntime.Notes
npm auditmay still report vulnerabilities after this upgrade — these are in transitive dependencies within@vercel/node's own tree and must be fixed upstream.npx tsc -p Tsconfig.json --noEmit) passes cleanly after the upgrade.Link to Devin session: https://app.devin.ai/sessions/7baffc795f3548ad908b161f4f5535a9
Requested by: @coder11125