Remove L1CaloGeometry tag from HLT GT

[francescobrivio]

Remove L1CaloGeometry_CRAFT09_hlt from the HLT GT in CMSSW_12_3_X once cms-sw/cmssw#36986 has been merged.

[tvami]

We can prob remove it from the MC GTs as well

[srimanob]

Do we miss when only L1Repack is used, as tested here,
cms-sw/cmssw#36940 (comment)

I don't know what will be that situation, but I think we should try to solve it all?

Do you have a GT to be tested with IB that includes cms-sw/cmssw#36986 (i.e. CMSSW_12_3_X_2022-02-17-2300)

[srimanob]

By the way, for the add-on test,
cms-sw/cmssw#36806 (comment)

What is the conclusion on the proper stepname, L1REPACK:Full or L1REPACK, because they are different.

[tvami]

Do you have a GT to be tested with IB that includes cms-sw/cmssw#36986 (i.e. CMSSW_12_3_X_2022-02-17-2300)

We do for data, but not for MC. For data just use 123X_dataRun3_HLT_v2

[tvami]

I'll write to Aaron about the L1REPACK:Full or L1REPACK question

[srimanob]

The test with the following cmsDriver (*) with CMSSW_12_3_X_2022-02-18-1100 (HLT PR includes) + 123X_dataRun3_HLT_v2 shows that

L1REPACK::FULL ==> OK

L1REPACK ==> Fail with

----- Begin Fatal Exception 18-Feb-2022 15:13:25 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'RAWoutput_step'
   [2] Prefetching for module PoolOutputModule/'RAWoutput'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1GTDigiToRaw/'l1GtPack'
   [5] Calling method for module L1GlobalTrigger/'simGtDigis'
Exception Message:
No "L1CaloGeometryRecord" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

This confirms the test on
cms-sw/cmssw#36806 (comment)

(*) Base on wf 139.001
cmsDriver.py step2 --process reHLT -s L1REPACK:Full --conditions 123X_dataRun3_HLT_v2 --data --eventcontent RAW --datatier RAW --era Run3 --python L1REPACKFULL_2021.py -n 100 --no_exec --filein filelist:step1_dasquery.log --lumiToProcess step1_lumiRanges.log --fileout file:step2.root

cmsDriver.py step2 --process reHLT -s L1REPACK --conditions 123X_dataRun3_HLT_v2 --data --eventcontent RAW --datatier RAW --era Run3 --python L1REPACK_2021.py -n 100 --no_exec --filein filelist:step1_dasquery.log --lumiToProcess step1_lumiRanges.log --fileout file:step2.root

[tvami]

Ok, great, thanks Phat for testing that. So one action item is to move all the L1REPACK-s to L1REPACK:Full in all the Run-3 RelVal wf-s. Will you follow-up on that? Thanks

[srimanob]

As far as I see on relvals_step,
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L1887-L1908
starting from 2016 we use L1REPACK:Full.

However I don't know where do you get cmsDriver as your comment in
cms-sw/cmssw#36806 (comment)
Somewhere in ALCA testing system?

Maybe we need a document somewhere and/or protection.

[tvami]

starting from 2016 we use L1REPACK:Full.

OK that's great! Thanks for checking

However I don't know where do you get cmsDriver as your comment in

Yeah, we'll fix that internally!