Hi, thanks for making this great library. It's particularly nice how few dependencies this library has compared to others. I noticed the trimesh[easy] extra is pulled in, when according to https://github.com/clemense/yourdfpy/pull/33/files, it's really only pycollada that is needed:
|
install_requires = |
|
importlib-metadata; python_version<"3.8" |
|
lxml |
|
trimesh[easy]>=3.11.2 |
|
numpy |
|
six |
I was wondering if you'd be open to explicitly enumerating your dependencies. For trimesh, the 'easy' extra pulls a bunch of extra dependencies that don't seem necessary to this library. Also, I noticed the other dependencies don't have version ranges they work with (e.g. >=2.2,<3.0 assumes no API changes in v2 range). I think these changes would make the library leaner and more likely to stand the test of time. If this works for you, I can make a PR with the change.
Hi, thanks for making this great library. It's particularly nice how few dependencies this library has compared to others. I noticed the
trimesh[easy]extra is pulled in, when according to https://github.com/clemense/yourdfpy/pull/33/files, it's really onlypycolladathat is needed:yourdfpy/setup.cfg
Lines 56 to 61 in e16b857
I was wondering if you'd be open to explicitly enumerating your dependencies. For trimesh, the 'easy' extra pulls a bunch of extra dependencies that don't seem necessary to this library. Also, I noticed the other dependencies don't have version ranges they work with (e.g.
>=2.2,<3.0assumes no API changes in v2 range). I think these changes would make the library leaner and more likely to stand the test of time. If this works for you, I can make a PR with the change.