refactor(naming): drop legacy 'mothership' label#21
Conversation
…l service name Replace 'chittyid-mothership' with 'chittyid' and 'ChittyID Mothership' with 'ChittyID' across live files. The Cloudflare Worker has been named 'chittyid' in wrangler.jsonc; this sweeps the lingering 'mothership' label out of code, prose, config, monitoring, scripts, and the /health response body to conform to the canonical Chitty<Word> service-naming rule. Minor breaking change: /health and X-ChittyOS-Service header now return 'chittyid' instead of 'chittyid-mothership'. Backup/original files (.bak/.original) and archived directories left untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (27)
📝 WalkthroughWalkthroughThis PR renames the service identifier from ChangesService Identity Refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb455f477b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| version: '2.0.0', | ||
| description: 'Identity management system with hardened security pipeline', | ||
| endpoint: 'https://chittyid-mothership.chitty.workers.dev', | ||
| endpoint: 'https://chittyid.chitty.workers.dev', |
There was a problem hiding this comment.
Advertise only a configured service endpoint
With the current worker config (wrangler.jsonc:9 sets workers_dev: false and the only route is id.chitty.cc/*), the renamed https://chittyid.chitty.workers.dev host is not served by this deployment. Registering that URL as the service endpoint makes registry consumers and later health updates probe an unreachable host after the rename; use the routed https://id.chitty.cc endpoint or enable workers.dev before advertising it.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in #22 (commit 8236bb6): endpoint now reads from env.CHITTYID_SERVICE_URL / SERVICE_PUBLIC_URL, falling back to https://id.chitty.cc. No hardcoded workers.dev URL.
| */ | ||
|
|
||
| const WORKER_URL = process.env.NOTION_SYNC_WORKER_URL || 'https://notion-sync.chittyid-mothership.workers.dev'; | ||
| const WORKER_URL = process.env.NOTION_SYNC_WORKER_URL || 'https://notion-sync.chittyid.workers.dev'; |
There was a problem hiding this comment.
Keep the NotionSync workers.dev subdomain unchanged
When NOTION_SYNC_WORKER_URL is not set, the monitor now probes notion-sync.chittyid.workers.dev; in a workers.dev URL the segment after the worker name is the Cloudflare account subdomain, so renaming the ChittyID service label does not move the separate notion-sync worker from the existing chittyid-mothership subdomain. This default will make the health checks report the NotionSync worker as unreachable unless every environment overrides it.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
chittyid-mothershipwithchittyidandChittyID MothershipwithChittyIDacross 27 live files (code, prose, config, monitoring, scripts).wrangler.jsoncand the canonicalChitty<Word>service-naming rule.Breaking change (minor)
/healthresponse andX-ChittyOS-Serviceheader now returnchittyidinstead ofchittyid-mothership.CHITTYOS/chittyops/spec/daily-updates-orchestration-v0.5.md:172. No runtime matcher found.Scope
*.bak/*.originalfiles.Test plan
node --checkon touched JS / function modulesSummary by CodeRabbit
Chores
Documentation