Skip to content

chore: rm orphan notion-sync.ts copies#32

Open
chitcommit wants to merge 1 commit into
mainfrom
chore/notion-killlist-orphan-sync
Open

chore: rm orphan notion-sync.ts copies#32
chitcommit wants to merge 1 commit into
mainfrom
chore/notion-killlist-orphan-sync

Conversation

@chitcommit

@chitcommit chitcommit commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Part of notion search-and-destroy. Both copies MD5-identical and outside tsconfig include — unbuilt, unimported. See chittycanon://gov/killlist/2026-06-02-notion.

Summary by CodeRabbit

  • Chores
    • Removed Notion integration module, including session synchronization and GitHub workflow status tracking features that synced to Notion dashboards.

Both copies were MD5-identical (45723e4b30dfd91864ec2d7cd6954abc) and
outside tsconfig.json include (client/src, shared, server) — never built,
never imported.

Refs: chittycanon://gov/killlist/2026-06-02-notion

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fda556a7-8a8d-498f-b307-3976ecb47d99

📥 Commits

Reviewing files that changed from the base of the PR and between a386bda and a340eb6.

📒 Files selected for processing (2)
  • cross-session-sync/notion-integration/notion-sync.ts
  • src/cross-session-sync/notion-integration/notion-sync.ts
💤 Files with no reviewable changes (2)
  • src/cross-session-sync/notion-integration/notion-sync.ts
  • cross-session-sync/notion-integration/notion-sync.ts

📝 Walkthrough

Walkthrough

This PR removes the entire Notion integration module, deleting 553 lines of code. The NotionSyncManager class and setupNotionIntegration function are removed, eliminating functionality for creating Notion session dashboards, managing task cards, syncing state from Neon databases, and reflecting GitHub Actions status in Notion callouts.

Changes

Cohort / File(s) Summary
Notion Integration Removal
src/cross-session-sync/notion-integration/notion-sync.ts, cross-session-sync/notion-integration/notion-sync.ts
Complete removal of NotionSyncManager class and setupNotionIntegration function (553 lines deleted), eliminating Notion dashboard creation, task card management, Neon database synchronization, and GitHub Actions status reflection.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A Notion module bids farewell today,
No more dashboards sync'd in Notion's way,
Yet leaves a void—are threads left hanging?
We search for callers, make sure nothing's breaking. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: rm orphan notion-sync.ts copies' is directly related to the changeset, which removes two duplicate, unused notion-sync.ts files located outside the build configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/notion-killlist-orphan-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a340eb6ddc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,553 +0,0 @@
import { Client } from '@notionhq/client';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore Notion init script target

When NOTION_TOKEN is set, both cross-session-sync/init-sync.sh:122-126 and src/cross-session-sync/init-sync.sh:122-126 enter notion-integration and run npx tsx notion-sync.ts create-dashboard; this deletion removes the only tracked file in that directory, so a fresh checkout no longer has the directory or script and initialization aborts under Notion-configured environments. Either keep this target or update the init scripts to use the replacement implementation before deleting it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant