From 0990420a5f9d82a4309fcd43012efb27056b7347 Mon Sep 17 00:00:00 2001
From: charlesLoder <charles.w.loder@gmail.com>
Date: Wed, 5 Aug 2026 14:12:33 -0400
Subject: [PATCH] fix: astro check warning

---
 eslint.config.js                         | 3 ++-
 netlify/edge-functions/check-theme.ts    | 2 +-
 src/components/SchemaOrg/SchemaOrg.astro | 5 ++---
 src/layouts/MainLayout.astro             | 3 ++-
 src/lib/schemaSerialization.ts           | 4 ++--
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/eslint.config.js b/eslint.config.js
index 51d7676..129bc88 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -1,11 +1,12 @@
 // eslint.config.js
 import js from "@eslint/js";
 import svelte from "eslint-plugin-svelte";
+import { defineConfig } from "eslint/config";
 import globals from "globals";
 import ts from "typescript-eslint";
 import svelteConfig from "./svelte.config.js";
 
-export default ts.config(
+export default defineConfig(
   {
     ignores: ["dist/", ".netlify", ".astro", ".vscode", "test-results"],
   },
diff --git a/netlify/edge-functions/check-theme.ts b/netlify/edge-functions/check-theme.ts
index 9834636..e4ba66d 100644
--- a/netlify/edge-functions/check-theme.ts
+++ b/netlify/edge-functions/check-theme.ts
@@ -1,6 +1,6 @@
 import type { Config, Context } from "@netlify/edge-functions";
 
-export default async (request: Request, context: Context) => {
+export default async (_: Request, context: Context) => {
   const response = await context.next();
 
   const contentType = response.headers.get("content-type");
diff --git a/src/components/SchemaOrg/SchemaOrg.astro b/src/components/SchemaOrg/SchemaOrg.astro
index 0d1e2e4..956bdf2 100644
--- a/src/components/SchemaOrg/SchemaOrg.astro
+++ b/src/components/SchemaOrg/SchemaOrg.astro
@@ -1,7 +1,6 @@
 ---
 interface Props {
   type: "webapplication" | "about";
-  url?: string;
 }
 
 const SITE_NAME = "Hebrew Transliteration App";
@@ -10,7 +9,7 @@ const SITE_URL = "https://hebrew-transliteration.app";
 const description =
   "Accurate Hebrew transliteration app for academic, religious, or personal needs, along with a suite of other tools for dealing with Hebrew texts.";
 
-const { type, url = SITE_URL } = Astro.props;
+const { type } = Astro.props;
 
 const baseSchema = {
   "@context": "https://schema.org",
@@ -64,4 +63,4 @@ const schema =
       };
 ---
 
-<script type="application/ld+json" set:html={JSON.stringify(schema)} />
+<script is:inline type="application/ld+json" set:html={JSON.stringify(schema)} />
diff --git a/src/layouts/MainLayout.astro b/src/layouts/MainLayout.astro
index b0f79c2..d5c6f4c 100644
--- a/src/layouts/MainLayout.astro
+++ b/src/layouts/MainLayout.astro
@@ -49,7 +49,7 @@ const canonicalUrl = new URL(
     <meta name="twitter:image" content={imageUrl} />
     <meta name="twitter:image:alt" content="Hebrew Transliteration App" />
     <meta http-equiv="Accept-CH" content="Sec-CH-Prefers-Color-Scheme" />
-    <script define:vars={{ gaId: import.meta.env.PUBLIC_GA_TAG_ID }}>
+    <script is:inline define:vars={{ gaId: import.meta.env.PUBLIC_GA_TAG_ID }}>
       (function () {
         if (!gaId) return;
         window.dataLayer = window.dataLayer || [];
@@ -63,6 +63,7 @@ const canonicalUrl = new URL(
     {
       import.meta.env.PUBLIC_GA_TAG_ID && (
         <script
+          is:inline
           async
           src={`https://www.googletagmanager.com/gtag/js?id=${import.meta.env.PUBLIC_GA_TAG_ID}`}
         />
diff --git a/src/lib/schemaSerialization.ts b/src/lib/schemaSerialization.ts
index 129c39c..e7336d0 100644
--- a/src/lib/schemaSerialization.ts
+++ b/src/lib/schemaSerialization.ts
@@ -7,7 +7,7 @@ export interface SerializableSchemaFeature {
   TRANSLITERATION: string | { __function: string };
 }
 
-export function serialize_value(key: string, value: unknown): unknown {
+export function serialize_value(value: unknown): unknown {
   if (typeof value === "function") {
     return { __function: value.toString() };
   }
@@ -57,7 +57,7 @@ export function serialize_object(obj: unknown): unknown {
 
   const result: Record<string, unknown> = {};
   for (const [key, value] of Object.entries(obj)) {
-    result[key] = serialize_value(key, serialize_object(value));
+    result[key] = serialize_value(serialize_object(value));
   }
   return result;
 }