docs: fix contributing links and branch guidance#398
Open
HappyG1lmore wants to merge 1 commit into
Open
Conversation
| - Example: `// Transaction represents a single blockchain transaction.` | ||
|
|
||
| - **Branch Strategy**: All pull requests should be: | ||
| - Based on the `development` branch |
Collaborator
There was a problem hiding this comment.
the development branch information is incorrect, merges should be done against the main branch at the moment, the actual code intended to be used in validators are the versioned releases but we do expect PR's to be merged againstmain
Author
There was a problem hiding this comment.
Thanks for clarifying. The current PR diff updates the branch guidance to target main only. I left the versioned-release validator note out of CONTRIBUTING to keep this patch focused, but can add that nuance if you want it documented there too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix stale and placeholder links in the contribution docs, and align branch guidance with the repository's default branch.
Changes Made
Testing