Description
src/fleet_session.rs contains two public async functions (start_session, end_session) that perform database I/O but have no tracing spans. The project spec (continuous-improvement.md) mandates that every async fn awaiting an external resource must be wrapped in a tracing::info_span!.
Actual Behavior
start_session calls reconcile_stale_sessions and upsert_agent_session (both DB writes) with no span. end_session calls update_agent_session_status with no span. Only tracing::debug! log events exist; no span boundary is set.
Expected Behavior
Both functions should be instrumented with #[tracing::instrument] or a manual tracing::info_span! so fleet lifecycle events are visible in traces.
Environment
- HEAD: 9d76476
- File:
src/fleet_session.rs
Description
src/fleet_session.rscontains two public async functions (start_session,end_session) that perform database I/O but have no tracing spans. The project spec (continuous-improvement.md) mandates that everyasync fnawaiting an external resource must be wrapped in atracing::info_span!.Actual Behavior
start_sessioncallsreconcile_stale_sessionsandupsert_agent_session(both DB writes) with no span.end_sessioncallsupdate_agent_session_statuswith no span. Onlytracing::debug!log events exist; no span boundary is set.Expected Behavior
Both functions should be instrumented with
#[tracing::instrument]or a manualtracing::info_span!so fleet lifecycle events are visible in traces.Environment
src/fleet_session.rs