Skip to content

conformance: gated must not count the claim — pr-claim is the human touch, not CI #391

Description

@bdelanghe

First measured run after #390 (snapshot run 34264517316): gate_ready 37 (right), but gated 90 of 90 and gate-absent 0. That is not evidence about CI: required-baseline requires pr-claim / pr-claim on every default branch, so "at least one required context" is true everywhere by construction. Meanwhile arming-lane-absent fired on 53 repos, including ~40 with no caller at all — repos where nothing about CI is required, so "green waits for a person" is the wrong sentence; "green decides nothing" is the right one.

Fix, in classifyRepo:

  • gated = at least one required context other than pr-claim / pr-claim. The claim is the passkey's rung, not a CI check (.github-private#913 keeps it deliberately outside the CI gate).
  • gate-absent = caller present and not gated — the standard runs and nothing requires it (the fail-open set). Expected ≈ 13 callers outside the 37 that lack their own gate.
  • arming-lane-absent = gated and no arming lane. Expected: the six repos with their own gate/schema aggregator (.github, .github-private, infra, keycard, claude-box, front-desk-scheduler) — true findings: their green waits for a person.
  • required_checks keeps listing every context, the claim included; gate_ready unchanged.

Tests: a rules fixture with only the claim required is gate-absent for a caller and nothing for a bare repo; RULES_37 still ready; totals in the summary test recomputed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    • Status
      In Progress

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions