Regression: Panic on playback of MP3 in version 0.8.0

[zerfix]

I tried upgrading to awedio version 0.8.0, witch panics my program every time i load a MP3 track.
FLAC still works.
MP3 works in awedio version 0.7.0.

Error

awedio-0.8.0/src/sounds/decoders/symphonia.rs:187:29: Unknown panic

Stacktrace:

 8: awedio::sounds::decoders::symphonia::extract_sample::hfc07d17702bf2555
    at awedio-0.8.0/src/sounds/decoders/symphonia.rs:187
 9: awedio::sounds::decoders::symphonia::extract_sample_from_ref::h2c38df8ed16a8aa4
    at awedio-0.8.0/src/sounds/decoders/symphonia.rs:174
10: <awedio::sounds::decoders::symphonia::SymphoniaDecoder as awedio::sound::Sound>::next_sample::h4522fb77dd44ac92
    at awedio-0.8.0/src/sounds/decoders/symphonia.rs:107
11: <alloc::boxed::Box<dyn awedio::sound::Sound> as awedio::sound::Sound>::next_sample::h7e4826a756a5c20e
    at awedio-0.8.0/src/sound.rs:311
12: awedio::sounds::memory_sound::MemorySound::from_sound::h765aeb59f15e79d5
    at awedio-0.8.0/src/sounds/memory_sound.rs:53
13: awedio::sound::Sound::into_memory_sound::h70c3d42ed6d71f31
    at awedio-0.8.0/src/sound.rs:100

14: music_player::state::state_playback::load_memory_sound::h5d504b67389009ce
    at music_player/src/state/state_playback.rs:482
15: music_player::state::state_playback::load_track::{{closure}}::{{closure}}::h52d976b860c19944
    at music_player/src/state/state_playback.rs:472
16: music_player::state::state_playback::load_track::{{closure}}::h1e52bec97b5503e7
    at music_player/src/run.rs:25

My code

[dependencies]
awedio = '0.8.0'

music_player/src/state/state_playback.rs Line 482:

fn load_memory_sound(path: Box<Path>) -> Result<MemorySound> {
    Ok(open_file(path)?.into_memory_sound()?)
}

[benhansen-io]

Does it happen for all mp3 files?

What OS are you running on?

The following works inside the awedio repo:

cargo run --example play -- test_files/stereo-test.mp3

Can you try playing that same file with your project and see if it works.

The "Unknown Panic" is really weird. I haven't seen that before. That line isn't doing a whole lot, there is an unwrap there but that should give an "Unknown Panic"

[zerfix]

Ah, Unknown Panic is my internal error when the panic error message is of type String, instead of the &str i expected 😅.

The real error message is index out of bounds: the len is 0 but the index is 0.
The example play code works. Maybe the issue only happens when using MemorySound?

Looks like its not all MP3 tracks that are affected like i first thought.
Some albums are unaffected. And those albums who are affected, it looks like its not all of the tracks. The albums that works, all seem to be some of my most recent in my collection.
Tho i'm not certain, as it's a bit tedious to test with it hard crashing.

I have run mp3val on some of the tracks that are failing, and it reports no issues.

os: Linux, NixOS unstable
rust: 1.96.1

❯ ldd target/release/music_player
	linux-vdso.so.1 (0x0000719446306000)
	libasound.so.2 => /nix/store/6v3x79khipmf0zbn2yivvx7n15jccv47-alsa-lib-1.2.16/lib/libasound.so.2 (0x00007194461cf000)
	libgcc_s.so.1 => /nix/store/8lahnh9pn3lrrnhax5nk7ibvjcbjmnkm-gcc-15.2.0-lib/lib/libgcc_s.so.1 (0x0000719445bd3000)
	libm.so.6 => /nix/store/ias8xacs1h3jy7xgwi2awvim61k2ji6c-glibc-2.42-67/lib/libm.so.6 (0x0000719445adb000)
	libc.so.6 => /nix/store/ias8xacs1h3jy7xgwi2awvim61k2ji6c-glibc-2.42-67/lib/libc.so.6 (0x0000719445800000)
	libpthread.so.0 => /nix/store/ias8xacs1h3jy7xgwi2awvim61k2ji6c-glibc-2.42-67/lib/libpthread.so.0 (0x00007194461c8000)
	librt.so.1 => /nix/store/ias8xacs1h3jy7xgwi2awvim61k2ji6c-glibc-2.42-67/lib/librt.so.1 (0x00007194461c3000)
	/nix/store/ias8xacs1h3jy7xgwi2awvim61k2ji6c-glibc-2.42-67/lib/ld-linux-x86-64.so.2 => /nix/store/ias8xacs1h3jy7xgwi2awvim61k2ji6c-glibc-2.42-67/lib64/ld-linux-x86-64.so.2 (0x0000719446308000)

[zerfix]

If i change the example play to use memory sound, the error is reproduced.

examples/play-memory.rs:

use awedio::Sound;

fn main() -> Result<(), Box<dyn std::error::Error>> {
    let Some(file_path) = args() else {
        eprintln!("usage: FILE_PATH");
        std::process::exit(2);
    };

    let (mut manager, _backend) = awedio::start()?;
    let (sound, notifier) = awedio::sounds::open_file(file_path)?.into_memory_sound()?.with_completion_notifier();

    manager.play(Box::new(sound));
    let _ = notifier.recv();

    Ok(())
}

fn args() -> Option<String> {
    let mut args = std::env::args();
    args.next()?;
    args.next()
}

❯ cargo run --example play-memory -- <track>
<...>
thread 'main' (40910) panicked at src/sounds/decoders/symphonia.rs:187:29:
index out of bounds: the len is 0 but the index is 0