Skip to content

fix wrong return type in accessor#504

Merged
Becheler merged 1 commit into
boostorg:developfrom
Becheler:fix/sparse-ordering-eccentricity-narrowing
Jun 8, 2026
Merged

fix wrong return type in accessor#504
Becheler merged 1 commit into
boostorg:developfrom
Becheler:fix/sparse-ordering-eccentricity-narrowing

Conversation

@Becheler

@Becheler Becheler commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Refs #496

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

Removes ~15 warnings due to a cast from int to size_t to int.

Motivation

Refs #496

Testing

Same CI, less warnings.

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 27120341592 vs develop run 27120109824 (7ac2ddff07).

Job Baseline After Delta
macos (clang, 14) 75 75 0
macos (clang, 17) 70 70 0
macos (clang, 20) 70 70 0
ubuntu (clang-19, 14) 75 75 0
ubuntu (clang-19, 17) 75 75 0
ubuntu (clang-19, 20) 75 75 0
ubuntu (clang-19, 23) 75 75 0
ubuntu (gcc-14, 14) 51 51 0
ubuntu (gcc-14, 17) 51 51 0
ubuntu (gcc-14, 20) 51 51 0
ubuntu (gcc-14, 23) 51 51 0
windows_msvc_14_3 (msvc-14.3) 1226 1211 -15

@Becheler Becheler marked this pull request as ready for review June 8, 2026 07:10
@Becheler Becheler requested a review from jeremy-murphy as a code owner June 8, 2026 07:10
@Becheler Becheler merged commit a1ac741 into boostorg:develop Jun 8, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant