Cannot get fetch_roms.py working. Ubuntu server and Windows wsl ubuntu

[dabonetn]

Issuing the command 'BASEURL=http://bitfixer.com make fetch_roms' I get the following error.
I also get this trying to use the zimmers pet rom directory as the base.

user@ubuntu-compiler:~/bf-romulator$ BASEURL=http://bitfixer.com make fetch_roms
mkdir -p roms
#cd bin; python ../tools/fetch_roms.py /home/user/bf-romulator/config/memory_set_default.csv http://bitfixer.com
cd roms; python ../tools/fetch_roms.py /home/user/bf-romulator/config/memory_set_default.csv http://bitfixer.com
Traceback (most recent call last):
File "../tools/fetch_roms.py", line 26, in
for row in romreader:
_csv.Error: iterator should return strings, not bytes (did you open the file in text mode?)
make: *** [Makefile:85: fetch_roms] Error 1

Any suggestions?

[lagomorph]

You could try changing line 24 of fetch_roms.py from:
with open(csvfile, 'rb') as csvfile:
to:
with open(csvfile, 'r') as csvfile:

python3 wants it to be opened in text mode

[bitfixer]

Sorry for the delay, will give this a try on ubuntu today to see what I can find. Sounds like it may indeed be that file mode switch.

…

On Mon, May 23, 2022 at 12:57 PM John Scarfone ***@***.***> wrote: You could try changing line 24 of fetch_roms.py from: with open(csvfile, 'rb') as csvfile: to: with open(csvfile, 'r') as csvfile: python3 wants it to be opened in text mode — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANYKOMTBACRO5IMFSPUGU3VLPPJHANCNFSM5WTYHTLA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[dabonetn]

Installing python2 python-is-python2 got it working. apparently python3 is the default for newer installs.

[lagomorph]

As of January 1st, 2020 python2 is no longer supported either.

[bitfixer]

I ditched the python script and rewrote the fetcher in c++, pushed up to master. Should work now with BASEURL=<url> make fetch_roms.

…

On Wed, May 25, 2022 at 3:16 PM John Scarfone ***@***.***> wrote: As of January 1st, 2020 python2 is no longer supported either. — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANYKOO34BTMGHKET54ITX3VL2RDLANCNFSM5WTYHTLA> . You are receiving this because you commented.Message ID: ***@***.***>

[cvpeck]

Python 2 is now deprecated on all platforms. Migration to Python 3 is recommended

…

Sent from my iPad

On 26 May 2022, at 8:00 am, dabonetn ***@***.***> wrote:  Installing python2 python-is-python2 got it working. apparently python3 is the default for newer installs. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

[dabonetn]

Just build a new vm and the new fetch rom now works.

The only complaint I have now, is that if you go ahead and do a git clone to grab the romulator tree, (instead of just grabbing the setup script)
and then run setup_linux.sh, it completes, and says everything is good, but then when you make romulator, it fails because
everything is actually setup in a bf-romulator/bf-romulator directory.

Maybe add a check to see if you are already in the bf-romulator directory when running the setup script?

[bitfixer]

Good idea, will do that.

…

On Sat, May 28, 2022 at 10:20 AM dabonetn ***@***.***> wrote: Just build a new vm and the new fetch rom now works. The only complaint I have now, is that if you go ahead and do a git clone to grab the romulator tree, (instead of just grabbing the setup script) and then run setup_linux.sh, it completes, and says everything is good, but then when you make romulator, it fails because everything is actually setup in a bf-romulator/bf-romulator directory. Maybe add a check to see if you are already in the bf-romulator directory when running the setup script? — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANYKOI4MCFJVNBG7ULOPTLVMJIURANCNFSM5WTYHTLA> . You are receiving this because you commented.Message ID: ***@***.***>