Skip to content

Swapped data/content values in onProductOptionsChanged event detail #2541

Description

@jorgespace

The onProductOptionsChanged event dispatched in the productOptionsChanged method currently has its data and content properties swapped, which contradicts the original intent of PR #2400.

detail: {
    content: productAttributesData,
    data: productAttributesContent,
}

The correct assignment should be:

detail: {
    content: productAttributesContent, 
    data: productAttributesData,
}

Impact:
This could affect any code listening to the onProductOptionsChanged event that expects the correct data in each property.

Suggested Fix:
Simple swap of the values in the event detail object to match their semantic meaning.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions