From 744153243ea3c6d08f4af331199f3760bf9edac6 Mon Sep 17 00:00:00 2001 From: panish16 Date: Thu, 19 Mar 2026 15:39:49 -0700 Subject: [PATCH] chore: upgrade to Node.js 24 --- .github/workflows/ci.yml | 2 +- Dockerfile | 2 +- devops/cloudbuild-pr.yaml | 4 ++-- package.json | 5 ++++- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b0fef6b6..066b3797 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: pay-ui-ci: uses: bcgov/bcregistry-sre/.github/workflows/frontend-ci.yaml@main with: - node_version: "20.5.1" + node_version: "24" app_name: "pay-ui" working_directory: "." codecov_flag: "payweb" diff --git a/Dockerfile b/Dockerfile index f1a3dd71..2565b487 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:20.5.1 as build-stage +FROM node:24 as build-stage WORKDIR /app COPY ./package*.json ./ RUN npm install diff --git a/devops/cloudbuild-pr.yaml b/devops/cloudbuild-pr.yaml index 85d350e2..41411ee4 100644 --- a/devops/cloudbuild-pr.yaml +++ b/devops/cloudbuild-pr.yaml @@ -1,6 +1,6 @@ steps: # install / setup ci - - name: node:20.5.1 + - name: node:24 entrypoint: npm dir: "." args: ['install'] @@ -15,7 +15,7 @@ steps: # # Generate the static site # - - name: node:20.5.1 + - name: node:24 dir: "." entrypoint: npm env: diff --git a/package.json b/package.json index 0c936a08..63d1f417 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ "npm": "^7.19.0", "pinia": "^2.1.7", "postcss-nesting": "^12.0.1", - "sbc-common-components": "^3.1.6", + "sbc-common-components": "^3.1.6", "vite": "^4.5.10", "vite-plugin-environment": "^1.1.3", "vite-plugin-rewrite-all": "^1.0.1", @@ -84,5 +84,8 @@ "peerDependencies": { "@vue/composition-api": "^1.7.1", "vue": "^2.6.11" + }, + "engines": { + "node": ">=24" } }