From 6e098ff7aa9da525b9b1c43ab8ac4ca341bcf6bd Mon Sep 17 00:00:00 2001 From: mruff-aeq Date: Thu, 9 Jul 2026 10:38:36 -0400 Subject: [PATCH 1/2] 34022-move-director-mailing-validation-to-schema --- .../services/filings/validations/change_of_directors.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/legal-api/src/legal_api/services/filings/validations/change_of_directors.py b/legal-api/src/legal_api/services/filings/validations/change_of_directors.py index eda11b6ae0..2e1c74c916 100644 --- a/legal-api/src/legal_api/services/filings/validations/change_of_directors.py +++ b/legal-api/src/legal_api/services/filings/validations/change_of_directors.py @@ -203,13 +203,7 @@ def validate_directors_addresses(business: Business, cod: dict) -> list: for address_type in Address.JSON_ADDRESS_TYPES: address = director.get(address_type) - if not address: - if business.legal_type in Business.CORPS: - msg.append({ - "error": f"missing {address_type}", - "path": f"/filing/changeOfDirectors/directors/{idx}/{address_type}" - }) - elif address_type == Address.JSON_MAILING: + if address and address_type == Address.JSON_MAILING: for field in mailing_required_fields: if not address.get(field): msg.append({ From 1f806f2f51b0407584f7e9b12b9666323af8579a Mon Sep 17 00:00:00 2001 From: mruff-aeq Date: Thu, 9 Jul 2026 10:38:36 -0400 Subject: [PATCH 2/2] 34022-move-director-mailing-validation-to-schema --- python/common/business-registry-model/poetry.lock | 10 +++++----- python/common/business-registry-model/pyproject.toml | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/python/common/business-registry-model/poetry.lock b/python/common/business-registry-model/poetry.lock index a089fb168a..981a33f357 100644 --- a/python/common/business-registry-model/poetry.lock +++ b/python/common/business-registry-model/poetry.lock @@ -1472,7 +1472,7 @@ rpds-py = ">=0.7.0" [[package]] name = "registry_schemas" -version = "2.18.73" +version = "2.18.74" description = "A short description of the project" optional = false python-versions = ">=3.6" @@ -1489,9 +1489,9 @@ strict-rfc3339 = "*" [package.source] type = "git" -url = "https://github.com/bcgov/business-schemas.git" -reference = "2.18.73" -resolved_reference = "e6999a46b6e38c52cc79f0e5a3c9fcbd0c473434" +url = "https://github.com/mruff-aeq/business-schemas.git" +reference = "34022-director-mailingaddress-required" +resolved_reference = "341f16ddc16829aa57e323cca497a4008e5fe52f" [[package]] name = "requests" @@ -2085,4 +2085,4 @@ files = [ [metadata] lock-version = "2.1" python-versions = ">=3.13,<3.14" -content-hash = "ec2f82cd063a03708cf9e5103b1de1002f0e75e06c995790c5cc6d53558e3a0e" +content-hash = "04b7d2eee0556a8916e50420a9fa6e6a66816375b6411654b197a6be11619b87" diff --git a/python/common/business-registry-model/pyproject.toml b/python/common/business-registry-model/pyproject.toml index 61a2a02288..fd8b8fb594 100644 --- a/python/common/business-registry-model/pyproject.toml +++ b/python/common/business-registry-model/pyproject.toml @@ -9,7 +9,7 @@ readme = "README.md" requires-python = ">=3.13,<3.14" dependencies = [ "sql-versioning @ git+https://github.com/bcgov/lear.git@main#subdirectory=python/common/sql-versioning-alt", - "registry-schemas @ git+https://github.com/bcgov/business-schemas.git@2.18.73", + "registry-schemas @ git+https://github.com/mruff-aeq/business-schemas.git@34022-director-mailingaddress-required", "flask-migrate (>=4.1.0,<5.0.0)", "pg8000 (>=1.31.2,<2.0.0)", "pydantic (>=2.10.6,<3.0.0)",