diff --git a/src/balderhub/waveform/lib/utils/waveforms/base_periodic_waveform.py b/src/balderhub/waveform/lib/utils/waveforms/base_periodic_waveform.py index 53377e0..d6729e1 100644 --- a/src/balderhub/waveform/lib/utils/waveforms/base_periodic_waveform.py +++ b/src/balderhub/waveform/lib/utils/waveforms/base_periodic_waveform.py @@ -161,9 +161,6 @@ def compare( max_allowed_rmse=max_allowed_rmse, ignore_phase=ignore_phase ) - # have the same type -> compare each other directly - if self.frequency_hz != with_waveform.frequency_hz: - return False if ignore_phase: return self.get_phase_difference_to(with_waveform, max_allowed_rmse=max_allowed_rmse) is not None @@ -172,6 +169,9 @@ def compare( self_signal = self.get_resampled_version(common_delta_time).get_data_in_volts() other_signal = with_waveform.get_resampled_version(common_delta_time).get_data_in_volts() + if len(self_signal) != len(other_signal): + return False + rmse = np.sqrt(np.mean((self_signal - other_signal) ** 2)) return rmse < max_allowed_rmse