validate mount options

[danie-dejager]

Could the mount options be validated? If incorrect entries are added, spelling mistakes or unsupported phrases are ussed? Can this be added as an improvement and added as an example?

[b10011]

Do you mean just the mount options (Entry.options)?

[danie-dejager]

Yeah. I have the following that kinda does what I want but not all options or file systems have been added:

#!/usr/bin/env python3

valid_options = [
    'defaults',
    'ro',
    'rw',
    'suid',
    'nosuid',
    'dev',
    'nodev',
    'exec',
    'noexec',
    'sync',
    'async',
    'dirsync',
    'atime',
    'noatime',
    'diratime',
    'nodiratime',
    'relatime',
    'norelatime',
    'bind',
    'nofail',
    'x-systemd.device-timeout'
]

valid_fs_types = [
    'ext2',
    'ext3',
    'ext4',
    'xfs',
    'zfs',
    'ntfs',
    'swap',
    'none',
    'vfat',
    'tmpfs'
]

error_found = False
bind_error_found = False

with open('/etc/fstab', 'r') as f:
    for line_num, line in enumerate(f, 1):
        line = line.strip()
        if line.startswith('#') or line == '':
            continue

        fields = line.split()
        if len(fields) < 6:
            print(f'Error (line {line_num}): Invalid line in /etc/fstab: {line}')
            error_found = True
            continue

        device, mount_point, fs_type, options, dump, passno = fields[:6]
        bind_error_found = False

        if fs_type not in valid_fs_types:
            print(f'Error (line {line_num}): Invalid file system type in /etc/fstab: {fs_type}')
            error_found = True

        if fs_type == 'tmpfs':
            if not [option.startswith ('size=') for option in options]:
                print(f'Error (line {line_num}): Missing size parameter in /etc/fstab: {line}')
                error_found = True
            else:
                size = int(options.split('=')[1].strip()[:-1])
                if size < 0:
                    print(f'Error (line {line_num}): Invalid size parameter in /etc/fstab: {line}')
                    error_found = True

        for option in options.split(','):
            if fs_type == 'tmpfs' and option.startswith ('size='):
                continue
            if option.startswith('x-systemd.device-timeout='):
                try:
                    timeout = int(option.split('=')[1])
                    if timeout < 0:
                        raise ValueError
                except ValueError:
                    print(f'Error (line {line_num}): Invalid x-systemd.device-timeout value in /etc/fstab: {option}')
                    error_found = True
            elif option not in valid_options:
                print(f'Error (line {line_num}): Invalid or unkown option in /etc/fstab: {option}')
                error_found = True
            elif option == 'bind':
                if fs_type not in ['none', 'tmpfs']:
                    if not bind_error_found:
                        print(f'Error (line {line_num}): The bind option is only valid when it is used in a bind mount, not for file system type {fs_type}')
                        error_found = True
                        bind_error_found = True

        if dump != '0' and dump != '1':
            print(f'Error (line {line_num}): Invalid dump value in /etc/fstab: {dump}')