Starting a second search operation does immediately run recent search without possibilty to enter a new query

[lizzi193]

Describe the bug

Whenever a search has been initiated and another one is attempted afterwards, you cannot enter a new search query. The virtual keyboard does not appear.

Instead, immediately after clicking 'Search' or 'Global Search' menu item, the plugin will run a search using the search term taken from the request before.

Entering a new search query is only possible after restarting the plugin.

Steps to reproduce

1. Open Plugin
2. Go to 'Search' (or 'Global Search')
3. Virtual Keyboard does open
4. Type in any search query
5. Enter
6. Go to 'Search' or 'Global Search' again in order to perform a new search or to refine

Expected behavior

• virtual keyboard does appear in order to type in a new search query or refine the previous one

Current Behaviour

• virtual keyboard does not appear
• search operation with recent search query does start immediately in the background
• results of the search operation before are listed as a result (or, in case of 'Global Search' after performing a 'Local Search', finishes with error response: 'Error.No Results were found. Please Try Another Feed.', related to Global Search does not response any results #8 )

Kodi Details

Device: Android TV
OS: Android TV 14.0.0 API Level 34 (kernel: Linux 5.15.170)
Kodi Version: 21.2

[ayaadev]

Hi there! Thanks again for creating an issue.

The search dialog should reappear after you go to the menu because in the menu code it explicitly requests a new search when you search again.

Are you somehow trying to create another search before going to the menu, or does this still happen after you load the menu and search again?

[lizzi193]

Thank you for your quick response.

In modern themes you link menu items to a position you can reach with one or two clicks without need to go through the hole menu branch.
So yes, I entered one of the search menu items directly without returning to the main menu of the plugin. Most likely is this where the problem lies.

Edit: Starting a search request from the plugin menu does not cause any problems. This is the only way to search for content at the moment.

[ayaadev]

Ah, okay. Thanks for letting me know. I use the default Kodi theme so I didn’t know that was possible. I believe I know how to fix this. If clicking on the search button instead returned a new directory of several past searches (so you can search again) plus an option to make a new search, do you think that would work with your theme? If you’ve ever used the YouTube Kodi add-on’s search function, I’m thinking about doing something similar to that.

[lizzi193]

Yes, this should be suitable for most custom themes.

There is one aspect to remember when dealing with the past searches function: There are many users who do not want to use serach history due to privacy aspects. So there should also be an option in plugin settings to disable it.

[ayaadev]

This should be fixed in version 1.1.0 of the add-on. It's been published to the add-on repository, but if the new version doesn't appear, you can try the following steps:

• Remove PeerTube Plus
• Remove AyaaDev Kodi Repository
• Follow steps 6 to 12 in the installation guide

I’m planning on adding an option to hide the search history in the future, but for now users can delete a search once they've finished searching.

Let me know if this issue still persists. If everything's fixed, I'll close this issue. Thanks for your feedback! It's made the add-on better for everyone 🎉

[lizzi193]

I will be able to test it tomorrow.

[ayaadev]

Hi there! I’m just wondering if this is fixed, and the issue can be closed now? Thanks.

[lizzi193]

Unfortunately, due to health issues, I haven’t been able to get round to it yet. I’m sorry about that.
I haven’t forgotten, and I’ll be in touch over the weekend.

[ayaadev]

No worries! I just wanted to check as I am going on holidays tomorrow for the next two weeks, and therefore unable to do much coding.

I hope everything's well regarding your health. Take care.

[lizzi193]

Thank you, I’m sure it’ll all work out.
I figured out some few more Issues last week. I will add them in the meantime. Don’t worry about it, we’ll go through them step by step when you’re back. Have a great holiday.

[ayaadev]

Thanks very much for helping to make this add-on better, and understanding about my holiday break! I appreciate it :)