0.9.2 compile failure

[jkroonza]

Describe the bug

FAILED: [code=1] CMakeFiles/aws-c-auth.dir/source/login_token_utils.c.o 
/usr/bin/x86_64-pc-linux-gnu-gcc -DAWS_AUTH_EXPORTS -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_ENABLE_EPOLL -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DCJSON_HIDE_SYMBOLS -DHAVE_SYSCONF -DINTEL_NO_ITTNOTIFY_API -Daws_c_auth_EXPORTS -I/var/tmp/portage/dev-libs/aws-c-auth-0.9.2/work/aws-c-auth-0.9.2/include  -O2 -march=native -pipe -frecord-gcc-switches -fno-common -std=gnu99 -fPIC -fvisibility=hidden -Wall -Wstrict-prototypes -fno-omit-frame-pointer -Wextra -pedantic -Wno-long-long -fPIC -MD -MT CMakeFiles/aws-c-auth.dir/source/login_token_utils.c.o -MF CMakeFiles/aws-c-auth.dir/source/login_token_utils.c.o.d -o CMakeFiles/aws-c-auth.dir/source/login_token_utils.c.o -c /var/tmp/portage/dev-libs/aws-c-auth-0.9.2/work/aws-c-auth-0.9.2/source/login_token_utils.c
/var/tmp/portage/dev-libs/aws-c-auth-0.9.2/work/aws-c-auth-0.9.2/source/login_token_utils.c: In function ‘s_base_64_url_length’:
/var/tmp/portage/dev-libs/aws-c-auth-0.9.2/work/aws-c-auth-0.9.2/source/login_token_utils.c:689:5: error: implicit declaration of function ‘aws_base64_url_compute_encoded_len’; did you mean ‘aws_base64_compute_encoded_len’? [-Wimplicit-function-declaration]
  689 |     aws_base64_url_compute_encoded_len(input_cursor->len, &encoded_length);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     aws_base64_compute_encoded_len
/var/tmp/portage/dev-libs/aws-c-auth-0.9.2/work/aws-c-auth-0.9.2/source/login_token_utils.c: In function ‘s_encode_base64_url’:
/var/tmp/portage/dev-libs/aws-c-auth-0.9.2/work/aws-c-auth-0.9.2/source/login_token_utils.c:696:12: error: implicit declaration of function ‘aws_base64_url_encode’; did you mean ‘aws_base64_encode’? [-Wimplicit-function-declaration]
  696 |     return aws_base64_url_encode(input_cursor, output);
      |            ^~~~~~~~~~~~~~~~~~~~~
      |            aws_base64_encode

This compiled successfully in 0.9.1

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

I expect the compile to succeed.

Current Behavior

Compile fails with the error as given.

Reproduction Steps

ninja -v -l0 -j1

Possible Solution

No response

Additional Information/Context

No response

aws-c-auth version used

0.9.2

Compiler and version used

gcc version 14.3.1

Operating System and version

Gentoo Linux

[TingDaoK]

you need to update the deps to latest as well. Specifically, aws-c-common to v0.12.6

[jkroonza]

should the CMakeLists file not specify the minimum supported version? Which would immediately point out the problem?

[DmitriyMusatkin]

we will consider that as feature request. its currently not possible since the versioning in cmake is not completely setup