Skip to content

Optimizing support of comic book files #17

Description

@schouffy

Hi,

I'm the creator of Cover comic reader on windows.
My app only wants to support comic books, so for the longest time I'd scrapped together a very crappy epub parser that would just list the images and display them in order.
Recently I've had issues with files that aren't supported, so instead of trying to add edge cases to my crappy thing, I've looked at alternatives and found yours.

It does work well, however I've noticed the following:

  • it consumes a lot of memory because it immediately loads all of the image to byte arrays
  • for the same reason, it takes a little bit more time to open the file
  • it doesn't support password protected files

A good way of improving it (for comic books at least) would be to:

  • only load the image content when they are requested (means the stream stays open, and it is disposed manually by the consumer). Could be a parameter when opening.
  • use another library such as SharpCompress to open zip files so password is supported (to my knowledge it's also better maintained than System.IO.Compression.ZipArchive)

I'm not asking that you do this, but I do plan to do it, and depending on whether you're interested in this, I can do pull requests when I'm done.
Let me know if you want this, and thanks for the library!
Jerome

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions