Fix/s3 host address#236
Merged
Merged
Conversation
lfbrehm
approved these changes
May 13, 2026
Member
lfbrehm
left a comment
lfbrehm
left a comment
There was a problem hiding this comment.
Thanks for fixing the host address issue. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This standardizes the configuration of the S3 interface across the codebase by removing the separate
S3_PORTenvironment variable and instead requiringS3_HOSTandS3_ADDRESSto include both host and port (e.g.,127.0.0.1:1337). This change simplifies configuration, improves clarity, and ensures consistency in how S3 endpoints are specified and used.