Skip to content

Track remaining low-risk cleanup from repository review #74

Description

@apstndb

Deferred from local repository review cleanup.

Context

The immediate repository hygiene and CLI safety/docs work is split into PRs, while larger architecture and jq streaming work is tracked separately. This issue keeps the remaining low-risk cleanup notes in one place so they are not lost.

Proposed cleanup items

  • Remove the dead debuglog global/init block, or wire it into an actual debug path.
  • Simplify enableTracing context cancellation if the extra context.WithCancel layer has no distinct cancellation semantics.
  • Revisit the unreachable readWrite branch in lazy jq output routing and either remove it or make the invariant explicit near the eager override.
  • Drop or use the currently unused mode parameter in jqresult.Compile.
  • Review the no-op isEncodeLeaf(v) branch in jqresult.NormalizeForEncode.
  • Consider rejecting NaN and +/-Inf parameters earlier with clearer messages instead of letting memebridge parsing surface a lower-level error.
  • Add a minimal .golangci.yml only if the repo wants lint behavior pinned beyond the version already set in GitHub Actions.

Acceptance criteria

  • Each cleanup is either implemented with focused tests or explicitly left out with a short rationale.
  • Existing golden tests continue to pass.
  • make lint and make test pass.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions