From 4e4420824dfde793eeb7917e6371f7d845e549dc Mon Sep 17 00:00:00 2001
From: Elliotte Rusty Harold <elharo@ibiblio.org>
Date: Sat, 4 Jul 2026 14:29:25 +0000
Subject: [PATCH] fix: make DependencyInfo.hashCode() consistent with equals()

equals() compares only the 'dependency' field, but hashCode()
incorrectly incorporated both 'dependency' and 'targetFileName',
violating the equals/hashCode contract. Now hashCode() uses only
'dependency', matching equals().

Fixes #620
---
 .../plugins/war/util/DependencyInfo.java      |  5 +-
 .../plugins/war/util/DependencyInfoTest.java  | 74 +++++++++++++++++++
 2 files changed, 75 insertions(+), 4 deletions(-)
 create mode 100644 src/test/java/org/apache/maven/plugins/war/util/DependencyInfoTest.java

diff --git a/src/main/java/org/apache/maven/plugins/war/util/DependencyInfo.java b/src/main/java/org/apache/maven/plugins/war/util/DependencyInfo.java
index 78906eb8..aa1f52b8 100644
--- a/src/main/java/org/apache/maven/plugins/war/util/DependencyInfo.java
+++ b/src/main/java/org/apache/maven/plugins/war/util/DependencyInfo.java
@@ -85,9 +85,6 @@ public boolean equals(Object o) {
 
     @Override
     public int hashCode() {
-        int result;
-        result = (dependency != null ? dependency.hashCode() : 0);
-        result = 31 * result + (targetFileName != null ? targetFileName.hashCode() : 0);
-        return result;
+        return dependency != null ? dependency.hashCode() : 0;
     }
 }
diff --git a/src/test/java/org/apache/maven/plugins/war/util/DependencyInfoTest.java b/src/test/java/org/apache/maven/plugins/war/util/DependencyInfoTest.java
new file mode 100644
index 00000000..c13946bb
--- /dev/null
+++ b/src/test/java/org/apache/maven/plugins/war/util/DependencyInfoTest.java
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.war.util;
+
+import org.apache.maven.model.Dependency;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+class DependencyInfoTest {
+
+    @Test
+    void equalsShouldBeBasedOnDependencyOnly() {
+        Dependency dep = new Dependency();
+        dep.setGroupId("g");
+        dep.setArtifactId("a");
+        dep.setVersion("1.0");
+
+        DependencyInfo info1 = new DependencyInfo(dep);
+        DependencyInfo info2 = new DependencyInfo(dep);
+        info2.setTargetFileName("different.txt");
+
+        assertEquals(info1, info2);
+    }
+
+    @Test
+    void hashCodeShouldBeConsistentWithEquals() {
+        Dependency dep = new Dependency();
+        dep.setGroupId("g");
+        dep.setArtifactId("a");
+        dep.setVersion("1.0");
+
+        DependencyInfo info1 = new DependencyInfo(dep);
+        DependencyInfo info2 = new DependencyInfo(dep);
+        info2.setTargetFileName("different.txt");
+
+        assertEquals(info1.hashCode(), info2.hashCode());
+    }
+
+    @Test
+    void equalsShouldReturnFalseForDifferentDependencies() {
+        Dependency dep1 = new Dependency();
+        dep1.setGroupId("g");
+        dep1.setArtifactId("a");
+        dep1.setVersion("1.0");
+
+        Dependency dep2 = new Dependency();
+        dep2.setGroupId("g");
+        dep2.setArtifactId("b");
+        dep2.setVersion("1.0");
+
+        DependencyInfo info1 = new DependencyInfo(dep1);
+        DependencyInfo info2 = new DependencyInfo(dep2);
+
+        assertNotEquals(info1, info2);
+    }
+}