test(desktop): eliminate the Settings/titlebar rename Escape race

[M4n5ter]

English

What happened

The Desktop E2E test opening settings commits an active titlebar rename is intermittent on Linux CI. After the test opens Settings while a titlebar rename is active and presses Escape, [data-maka-contract="titlebar-identity"] sometimes remains absent for the full 10-second assertion budget.

Expected behavior: once Settings is visible, one Escape closes it and the titlebar identity reappears with the committed name.

Observed behavior: the identity occasionally does not reappear. The same SHA passes when the CI job is rerun and passes as an isolated real-Electron test after a clean Desktop build, so this is a timing-dependent contract rather than a deterministic regression.

How to reproduce

Run the existing test on the built Desktop application:

npm --workspace @maka/desktop run build
npm exec -w @maka/desktop -- playwright test --config e2e/playwright.config.ts e2e/settings.spec.ts --grep "opening settings commits an active titlebar rename"

The failure is intermittent. The failing sequence is:

1. Create a Session.
2. Start an inline rename from the titlebar identity.
3. Enter a new name.
4. Programmatically activate Settings while the rename input retains focus.
5. Wait for Settings to become visible.
6. Press Escape once.
7. Observe that the titlebar identity sometimes remains unmounted.

Environment

• Maka commit: 82ba73f3bb30f2de2670f22fdb1d8471cb245ab8
• OS: GitHub-hosted Linux runner under Xvfb
• Surface: Desktop Electron E2E
• Test: apps/desktop/e2e/settings.spec.ts:39

Logs, screenshots, or additional context

• Failing CI job: locator [data-maka-contract="titlebar-identity"] was not found after Escape; 61 other E2E tests passed and one was skipped.
• Passing rerun of the same CI run and SHA.
• The isolated test also passes locally on the same SHA after @maka/desktop is fully built.
• PR fix(desktop): retire the owned local Host on full quit #3706 does not change renderer, Settings, titlebar, or this E2E. Its new paths execute only for full application quit or update installation, neither of which occurs in this test.
• Related behavior ownership: feat(desktop): state the session's project and name in the window titlebar #2327 introduced titlebar rename; fix(desktop): hide session chrome behind settings #2617 makes Settings unmount the session titlebar identity while Settings owns the window chrome.

The fix should establish which owner consumes Escape during the Settings transition and wait on the resulting observable state. Increasing the assertion timeout or adding a retry would hide the race rather than define the interaction contract.

简体中文

发生了什么

Desktop E2E 测试 opening settings commits an active titlebar rename 在 Linux CI 上存在间歇性失败。测试在标题栏重命名进行中打开 Settings 并按下 Escape 后，[data-maka-contract="titlebar-identity"] 偶尔在完整的 10 秒断言预算内都没有重新出现。

预期行为：Settings 可见后，按一次 Escape 会关闭 Settings，标题栏 identity 重新出现并显示已经提交的新名称。

实际行为：identity 偶尔不会重新出现。同一个 SHA 在 CI 重跑时通过，完整构建 Desktop 后单独运行同一条真实 Electron 测试也通过，因此这是一个依赖时序的交互契约问题，而不是确定性回归。

如何复现

在已构建的 Desktop 应用上运行现有测试：

npm --workspace @maka/desktop run build
npm exec -w @maka/desktop -- playwright test --config e2e/playwright.config.ts e2e/settings.spec.ts --grep "opening settings commits an active titlebar rename"

该失败是间歇性的。失败序列如下：

1. 创建一个 Session。
2. 从标题栏 identity 开始行内重命名。
3. 输入新名称。
4. 在重命名输入框仍持有焦点时，通过程序方式激活 Settings。
5. 等待 Settings 可见。
6. 按一次 Escape。
7. 标题栏 identity 偶尔仍处于卸载状态。

环境

• Maka commit：82ba73f3bb30f2de2670f22fdb1d8471cb245ab8
• OS：GitHub 托管的 Linux runner，使用 Xvfb
• Surface：Desktop Electron E2E
• 测试：apps/desktop/e2e/settings.spec.ts:39

日志、截图或其他上下文

• 失败的 CI job：按 Escape 后找不到 [data-maka-contract="titlebar-identity"]；其余 61 条 E2E 通过，1 条跳过。
• 同一 CI run、同一 SHA 的成功重跑。
• 在同一 SHA 上完整构建 @maka/desktop 后，本地单独运行该测试也通过。
• PR fix(desktop): retire the owned local Host on full quit #3706 没有修改 renderer、Settings、标题栏或该 E2E。新增路径只会在应用完整退出或安装更新时执行，而该测试不会触发这两个行为。
• 相关行为归属：feat(desktop): state the session's project and name in the window titlebar #2327 引入标题栏重命名；fix(desktop): hide session chrome behind settings #2617 规定 Settings 拥有窗口 chrome 时卸载 Session 标题栏 identity。

修复应明确 Settings 过渡期间由哪个 owner 消费 Escape，并等待最终可观察状态。增加断言 timeout 或 retry 只会掩盖竞态，不能定义交互契约。