From e60eb3c1c1ee73ff8859246e3c319410dc1647da Mon Sep 17 00:00:00 2001 From: Antoine Date: Sat, 5 Sep 2026 22:39:43 +0200 Subject: [PATCH] docs: correct a CI comment that denied the JavaScript suite MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A comment on the Java job said "There is no JavaScript test suite to run", forty lines above the web-ui-tests job that runs it. It was true when it was written and stopped being true when that suite landed. A reader taking the file at face value concludes the frontend is untested. The justification for skipping the frontend goals is unchanged and still correct — the cost, the npm registry, the risk of rewriting a tracked yarn.lock. Only the reason given for it being free was false, and it is replaced by the real one: the JavaScript suite has a job of its own. The header carried the same omission two lines from the top, describing one verdict where the workflow gives three. Correcting line 42 alone would have left the file half contradicting itself. Comments only. No step, no flag, no job changed; the diff contains no executable line. Co-Authored-By: Claude Opus 5 --- .github/workflows/ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ff7a195b1..4ec888d9f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,7 +2,7 @@ name: CI # Complements the `Nightly Build` workflow (maven.yml), which packages and publishes an artifact # from master. This one exists to give pull requests a verdict: it compiles every Java module and -# runs the test suite on both Linux and Windows. +# runs the Java suite on both Linux and Windows, and the JavaScript suite in a job of its own. # # Windows is not optional here. Several behaviours this project depends on — DOS file attributes, # whether a hidden file can be opened for writing, whether ATOMIC_MOVE is available — differ from @@ -39,8 +39,9 @@ jobs: # The frontend goals are skipped on purpose: they download Node 12 and run `yarn install`, # which costs ~2.5 minutes per platform, needs the npm registry, and can rewrite the tracked - # yarn.lock. There is no JavaScript test suite to run, and skipping them still compiles every - # Java module, web-ui included. Packaging the real bundle stays the nightly build's job. + # yarn.lock. No coverage is lost by skipping them here: the JavaScript suite has its own job + # below, and this one still compiles every Java module, web-ui included. Packaging the real + # bundle stays the nightly build's job. - name: Build and test shell: bash run: mvn -B -Dskip.installnodeyarn=true -Dskip.yarn=true test