Notifications say that user has forked/starred a repo that is not mine

[di]

On my profile page, I have notifications that say "User <name> forked your project <repository name> or "User <name> starred your project <repository name>, however sometimes these notifications are not about actual projects that are mine.

Instead, they seem to be other projects that a user which I follow is starring/forking that I am not responsible for (i.e., what would show up on my regular Github notification feed).

I would expect the notifications just to be for projects that I own, or at least to be able to unsubscribe from notifications about activity from users that I follow, but that doesn't seem to be an option.

Thanks for making a great tool!

[erfnzdeh]

This is a substring-matching bug in NotificationsChecker, and it explains the symptom exactly.

received_events is your activity feed, so it carries WatchEvent and ForkEvent for repositories owned by the people you follow — not only your own. Those get filtered down to owned repos with:

event[:repo][:name].include? user['login']

event[:repo][:name] is the full "owner/name", so this matches any repository whose owner or name merely contains your login as a substring.

@di, your login is two characters, which is why you saw it so often:

repo	include?("di")	owner compared exactly
redis/redis	notifies	skip
rails/audio-tools	notifies	skip
facebook/react-dialog	notifies	skip
someone/studio	notifies	skip
di/actual-repo	notifies	notifies

Which matches your description — "other projects that a user which I follow is starring/forking that I am not responsible for." Longer logins collide less often, but any repo named after you triggers the same thing.

Patch

Compare the owner segment exactly, case-insensitively since GitHub logins are case-insensitive:

--- a/workers/notifications_checker.rb
+++ b/workers/notifications_checker.rb
@@ -53,14 +53,21 @@ class NotificationsChecker
         page.each do |event|
           last_event_id = event[:id].to_i unless last_event_id > 0
           throw :break if event[:id].to_i <= user['last_event_id'].to_i
+          # The received events feed also carries activity from the people a
+          # user follows, so ownership has to be checked on the owner segment
+          # of "owner/name". A substring test matches any repo merely *named*
+          # after the user, which is why short logins get flooded with stars
+          # and forks on repositories they do not own.
+          repo_owner = event[:repo][:name].to_s.split('/').first.to_s
+          owns_repo = repo_owner.casecmp(user['login'].to_s).zero?
           case event[:type]
           when 'WatchEvent'
-            if event[:repo][:name].include? user['login']
+            if owns_repo
               puts "#{event[:actor][:login]} starred your project #{event[:repo][:name]}"
               on_new_event('star', event)
             end
           when 'ForkEvent'
-            if event[:repo][:name].include? user['login']
+            if owns_repo
               puts "#{event[:actor][:login]} forked your project #{event[:repo][:name]}"
               on_new_event('fork', event)
             end

casecmp rather than casecmp? to stay compatible with the Ruby versions this repo tags (2.2.4, 2.4.0). to_s guards a missing repo or login. Verified with ruby -c; the repo has no test suite.

Posting it here rather than as a branch so it stays applicable to anyone maintaining a fork. Same MIT terms as the project — use it freely, no attribution needed.