refactor: pipeline setup to run separate test harness configurations#59
Open
vulder wants to merge 16 commits into
Open
refactor: pipeline setup to run separate test harness configurations#59vulder wants to merge 16 commits into
vulder wants to merge 16 commits into
Conversation
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
4 times, most recently
from
3fd96f8 to
90e8a8b
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
from
90e8a8b to
1d7de4f
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
from
296951d to
ea0f937
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
from
6522202 to
7cad29d
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
13 times, most recently
from
7b7f519 to
cc865ce
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
from
cc865ce to
b58118e
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
from
0ad4398 to
1804225
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
5 times, most recently
from
b1f2efb to
adb934f
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
from
adb934f to
85ac218
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
2 times, most recently
from
98e8f9b to
6c3ebd7
Compare
vulder
force-pushed
the
refactor/pipeline-setup-and-add-tests
branch
from
6c3ebd7 to
1cddc5d
Compare
|
|
||
| // shared test helpers | ||
| #include "archive_test_helpers.h" | ||
| #include "sen/test_support//archive_test_helpers.h" |
Collaborator
There was a problem hiding this comment.
do we have two '/' here?
| add_subdirectory(test/util/calls_on_removal) | ||
| add_subdirectory(test/util/publish_types_manually) | ||
| add_subdirectory(test/util/query_test) | ||
| # TODO: Fix test that fails on arm |
Collaborator
There was a problem hiding this comment.
I would suggest to bind this TODO (and others in the code) to tickets for keeping track.
| add_subdirectory(integration/crash_report) | ||
| add_subdirectory(integration/type_clash) | ||
|
|
||
| # TODO: Need to figure out github support |
Collaborator
There was a problem hiding this comment.
Is this related to the usage of containers? We should also add a ticket reference for this TODO.
|
|
||
| // shared test helpers | ||
| #include "archive_test_helpers.h" | ||
| #include "sen/test_support//archive_test_helpers.h" |
Collaborator
There was a problem hiding this comment.
do we have // here?
| elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | ||
| target_compile_options(${target_name} PRIVATE ${common_clang_gcc_options_}) | ||
| set(suppress_gcc_broken_analysis_options | ||
| # std::variant |
Collaborator
There was a problem hiding this comment.
I would prefer to add a bit more info here about why we are suppressing these warnings. I know at some point I knew, but I don't remember anymore.
| export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH" | ||
| cmake --build build/${{ matrix.compiler.name }}/${{ matrix.build_type }}/ --target run_tests | ||
|
|
||
| # Connect App to Airbus Org. |
Collaborator
There was a problem hiding this comment.
should we keep this comment here? or leave a TODO (and a ticket)? I have the feeling that if we leave it like this it might get forgotten.
| ), | ||
| include_in_release_workflow=True, | ||
| include_in_conan_workflow=True, | ||
| # TODO: fix build failures in test setup |
Collaborator
There was a problem hiding this comment.
what's this one (and the one below) referring to?
EnriqueParodi
requested changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.