From 4f02660ffd215efc63fdf5e509fa7808462d6508 Mon Sep 17 00:00:00 2001 From: Thierry BOULOGNE Date: Sat, 9 Nov 2019 13:45:17 +0100 Subject: [PATCH 1/2] pattern_name as reverse --- navutils/menu.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/navutils/menu.py b/navutils/menu.py index 50b7d50..3c51923 100644 --- a/navutils/menu.py +++ b/navutils/menu.py @@ -109,11 +109,7 @@ def get_url(self, **kwargs): :return: The target URL of the node, after reversing (if needed) """ if self.pattern_name: - expected_kwargs = { - key: value for key, value in kwargs.items() - if key in self.reverse_kwargs - } - return reverse(self.pattern_name, kwargs=expected_kwargs) + return reverse(self.pattern_name[0], args=self.pattern_name[1]) return self.url def add(self, node): From 5882f72153de6ed70ed11ce97c89c395e3ed022e Mon Sep 17 00:00:00 2001 From: Thierry BOULOGNE Date: Sat, 9 Nov 2019 14:02:22 +0100 Subject: [PATCH 2/2] adopt reverse notation --- navutils/menu.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/navutils/menu.py b/navutils/menu.py index 3c51923..7943185 100644 --- a/navutils/menu.py +++ b/navutils/menu.py @@ -109,7 +109,10 @@ def get_url(self, **kwargs): :return: The target URL of the node, after reversing (if needed) """ if self.pattern_name: - return reverse(self.pattern_name[0], args=self.pattern_name[1]) + args = False + if len(self.pattern_name)>1: + args = self.pattern_name[1] + return reverse(self.pattern_name[0], args=args) return self.url def add(self, node):