Skip to content

Match working publish config from absmartly-cli-ts#14

Merged
joalves merged 1 commit into
mainfrom
fix/remove-registry-url
Apr 14, 2026
Merged

Match working publish config from absmartly-cli-ts#14
joalves merged 1 commit into
mainfrom
fix/remove-registry-url

Conversation

@joalves
Copy link
Copy Markdown
Collaborator

@joalves joalves commented Apr 14, 2026

Remove registry-url from setup-node — it overrides the OIDC auth flow by creating an .npmrc expecting NODE_AUTH_TOKEN. Now matches the working pattern from absmartly-cli-ts exactly.

Summary by CodeRabbit

  • Chores
    • Refined GitHub Actions publish workflow configuration with updated permissions ordering, modified build tool and runtime version specifications, and simplified action parameter settings to improve consistency and maintainability of the deployment pipeline.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5d6813aa-1f36-43cf-8778-7bdc5cd6ca78

📥 Commits

Reviewing files that changed from the base of the PR and between 9ea3520 and 643ac13.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml

Walkthrough

The pull request modifies the GitHub Actions workflow publication configuration. Changes include reordering job permission entries to align id-token: write after contents: read, removing the explicit bun-version: latest input to rely on default behaviour, quoting the Node version number in actions/setup-node@v4, and eliminating the explicit npm registry URL configuration.

Estimated Code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through workflows with care,
Permissions reordered with flair,
Defaults now trusted, no need to spell,
Quotes on the versions, all's well!
Simpler configurations everywhere! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly matches the PR's main objective of aligning the publish workflow configuration with the working pattern from absmartly-cli-ts, and accurately reflects the changes made to the workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-registry-url

Comment @coderabbitai help to get the list of available commands and usage tips.

@joalves joalves merged commit 8eeac9f into main Apr 14, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant