Skip to content

slashkit: build_all.sh calls missing ./build_rp1.sh (breaks RP1 firmware baking) #131

@amd-vserbu

Description

@amd-vserbu

Summary

linker/slashkit/resources/aved/build_all.sh invokes ./build_rp1.sh in the RP1 firmware directory, but no build_rp1.sh script exists in the RP1 resources (the RP1 firmware is built via its CMakeLists.txt). The AVED build aborts at this step.

Location

linker/slashkit/resources/aved/build_all.sh:44

# Step RP1 FW
RP1_DIR=$(realpath ./../../fw/RP1)
pushd ${RP1_DIR}
  ./build_rp1.sh
  cp -a ${RP1_DIR}/build/rp1.elf ${HW_DIR}/build
popd

Details

  • linker/resources/aved/rp1/ ships a CMakeLists.txt (cross-compiles rp1.elf with arm-none-eabi-gcc), but there is no build_rp1.sh.
  • Either add a build_rp1.sh wrapper that drives the CMake build and emits build/rp1.elf, or replace the call with the equivalent cmake/ninja invocation.

Impact

Together with the undefined config.resources_dir reference in project_gen.py, this breaks the static-shell package flow's RP1-baking path (worked around manually for the rp1_graph_vbin_full bring-up).

Found on the feature/hsa branch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions