Summary
generate_base_pdi_with_aved in linker/slashkit/emit/hw/project_gen.py references config.resources_dir, but CommandConfiguration (linker/slashkit/core/command_config.py) defines no such attribute/property. When this code path runs it raises AttributeError, breaking the static-shell package flow's RP1-firmware-baking step.
Location
linker/slashkit/emit/hw/project_gen.py:186
# Copy RP1 firmware sources into the AVED build tree
rp1_src_dir = config.resources_dir / "aved" / "rp1"
rp1_dest_dir = aved_dir / "fw" / "RP1"
if rp1_src_dir.is_dir():
shutil.copytree(rp1_src_dir, rp1_dest_dir, dirs_exist_ok=True)
Details
CommandConfiguration has no resources_dir member, so config.resources_dir throws AttributeError.
- The rest of this function locates bundled resources via
importlib.resources (resources.path("slashkit.resources.aved", ...)), so the RP1 source copy should use the same mechanism (e.g. importlib.resources for slashkit.resources.aved.rp1) rather than a nonexistent config attribute.
Impact
Together with the missing build_rp1.sh referenced by build_all.sh, this breaks the static-shell package flow's RP1-baking path (worked around manually for the rp1_graph_vbin_full bring-up).
Found on the feature/hsa branch.
Summary
generate_base_pdi_with_avedinlinker/slashkit/emit/hw/project_gen.pyreferencesconfig.resources_dir, butCommandConfiguration(linker/slashkit/core/command_config.py) defines no such attribute/property. When this code path runs it raisesAttributeError, breaking the static-shell package flow's RP1-firmware-baking step.Location
linker/slashkit/emit/hw/project_gen.py:186Details
CommandConfigurationhas noresources_dirmember, soconfig.resources_dirthrowsAttributeError.importlib.resources(resources.path("slashkit.resources.aved", ...)), so the RP1 source copy should use the same mechanism (e.g.importlib.resourcesforslashkit.resources.aved.rp1) rather than a nonexistent config attribute.Impact
Together with the missing
build_rp1.shreferenced bybuild_all.sh, this breaks the static-shell package flow's RP1-baking path (worked around manually for the rp1_graph_vbin_full bring-up).Found on the
feature/hsabranch.