From 4f7a0b20018cf4a423330a3d499a6c83f96ac886 Mon Sep 17 00:00:00 2001 From: Brad Byrd Date: Fri, 14 Aug 2026 06:22:49 -0500 Subject: [PATCH] fix(test): gate Value import behind cfg(unix) in filesystem_mode_test #694 consolidated the test helpers into tests/common/mod.rs, removing the top-level `get_global(..) -> Value` and `expect_text(&Value)`. That left the `Value` import with exactly one remaining reference, inside `#[cfg(unix)] mod unix`, so on Windows the import is dead and `cargo clippy -- -D warnings` fails the whole nightly Windows job. The break reached main because #694 merged during the Actions allowlist outage (#695) with zero CI: its run was a startup_failure, so no clippy job ever executed. Red: `cargo clippy --test filesystem_mode_test --all-features -- -D warnings` on Windows reproduces `error: unused import: wfl::interpreter::value::Value`, matching nightly run 31795283997 exactly. Green after this change, with the 4 tests in the file still passing. Refs #695 Co-Authored-By: Claude Opus 5 --- tests/filesystem_mode_test.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/filesystem_mode_test.rs b/tests/filesystem_mode_test.rs index 73db6cc6..e7c78fc7 100644 --- a/tests/filesystem_mode_test.rs +++ b/tests/filesystem_mode_test.rs @@ -9,6 +9,9 @@ // unsupported error — never a silent no-op, which is the failure mode the issue // complains about. +// `Value` is only referenced from the `unix` module below; on Windows the import +// would be dead and `-D warnings` rejects it. +#[cfg(unix)] use wfl::interpreter::value::Value; mod common;