From 6846b30fabed8fd73fb6a537a506db1946e47928 Mon Sep 17 00:00:00 2001 From: darshanime Date: Sun, 16 Aug 2026 21:56:09 +0530 Subject: [PATCH 1/3] pin versions, use env vars --- .github/workflows/test.yml | 2 +- .github/workflows/update-main-version.yml | 9 +++++++-- images/test-ubuntu-git.Dockerfile | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4740daf61..39aa44e08 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -188,7 +188,7 @@ jobs: # Worktree credentials in container step - name: Verify worktree credentials in container step if: runner.os == 'Linux' - uses: docker://bitnami/git:latest + uses: docker://bitnami/git@sha256:39cfadda7f52efd82655b71bfe5aecac4c7d64e7f8a581d8d49715f665293a7a with: args: bash __test__/verify-worktree.sh worktree-test container-worktree-branch diff --git a/.github/workflows/update-main-version.yml b/.github/workflows/update-main-version.yml index 0bbb121c7..05c2d26e2 100644 --- a/.github/workflows/update-main-version.yml +++ b/.github/workflows/update-main-version.yml @@ -31,6 +31,11 @@ jobs: git config user.name "github-actions[bot]" git config user.email "41898282+github-actions[bot]@users.noreply.github.com" - name: Tag new target - run: git tag -f ${{ github.event.inputs.major_version }} ${{ github.event.inputs.target }} + env: + MAJOR_VERSION: ${{ github.event.inputs.major_version }} + TARGET: ${{ github.event.inputs.target }} + run: git tag -f "$MAJOR_VERSION" "$TARGET" - name: Push new tag - run: git push origin ${{ github.event.inputs.major_version }} --force + env: + MAJOR_VERSION: ${{ github.event.inputs.major_version }} + run: git push origin "$MAJOR_VERSION" --force diff --git a/images/test-ubuntu-git.Dockerfile b/images/test-ubuntu-git.Dockerfile index 8b464c3d7..c579327db 100644 --- a/images/test-ubuntu-git.Dockerfile +++ b/images/test-ubuntu-git.Dockerfile @@ -1,7 +1,7 @@ # Defines the test-ubuntu-git Container Image. # Consumed by actions/checkout CI/CD validation workflows. -FROM ubuntu:latest +FROM ubuntu:26.04@sha256:678c6550cc43645e08669028bc177f50be4e7c5b8cca677067b1914d4afc7a03 RUN apt update RUN apt install -y git From 4f69ba46d58393a3943fabc0465ba4a7af54b66e Mon Sep 17 00:00:00 2001 From: darshanime Date: Sun, 16 Aug 2026 22:11:27 +0530 Subject: [PATCH 2/3] fix linter --- src/warpbuild/mirror-cache.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/warpbuild/mirror-cache.ts b/src/warpbuild/mirror-cache.ts index 8c1644884..81bc5b322 100644 --- a/src/warpbuild/mirror-cache.ts +++ b/src/warpbuild/mirror-cache.ts @@ -624,7 +624,7 @@ async function downloadTo( ) return } - const segments: [number, number][] = [] + const segments: Array<[number, number]> = [] for (let off = 0; off < total; off += SEGMENT_SIZE) { segments.push([off, Math.min(SEGMENT_SIZE, total - off)]) } @@ -643,7 +643,7 @@ async function downloadTo( await fh.write(buf, 0, count, offset) } } - const pool: Promise[] = [] + const pool: Array> = [] for (let k = 0; k < width; k++) { pool.push(worker()) } From c687f04ddf90d6fa013ee399aa23945b778b12cc Mon Sep 17 00:00:00 2001 From: darshanime Date: Mon, 17 Aug 2026 08:10:14 +0530 Subject: [PATCH 3/3] remove codeql advanced workflow CodeQL default setup is enabled on this repo, so the advanced workflow's SARIF upload is rejected every run: CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled Default setup already scans src/ and passes as "Analyze (javascript-typescript)". This file was the stock upstream template with no custom queries, so nothing is lost by dropping it. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/codeql-analysis.yml | 58 --------------------------- images/test-ubuntu-git.Dockerfile | 2 +- 2 files changed, 1 insertion(+), 59 deletions(-) delete mode 100644 .github/workflows/codeql-analysis.yml diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml deleted file mode 100644 index d3fc1a075..000000000 --- a/.github/workflows/codeql-analysis.yml +++ /dev/null @@ -1,58 +0,0 @@ -# For most projects, this workflow file will not need changing; you simply need -# to commit it to your repository. -# -# You may wish to alter this file to override the set of languages analyzed, -# or to provide custom queries or build logic. -# -# ******** NOTE ******** -# We have attempted to detect the languages in your repository. Please check -# the `language` matrix defined below to confirm you have the correct set of -# supported CodeQL languages. -# -name: "CodeQL" - -on: - push: - branches: [ main ] - pull_request: - # The branches below must be a subset of the branches above - branches: [ main ] - schedule: - - cron: '28 9 * * 0' - -jobs: - analyze: - name: Analyze - runs-on: ubuntu-latest - permissions: - actions: read - contents: read - security-events: write - - strategy: - fail-fast: false - matrix: - language: [ 'javascript' ] - # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ] - # Learn more: - # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed - - steps: - - name: Checkout repository - uses: actions/checkout@v7 - - - name: Initialize CodeQL - uses: github/codeql-action/init@v4 - with: - languages: ${{ matrix.language }} - # If you wish to specify custom queries, you can do so here or in a config file. - # By default, queries listed here will override any specified in a config file. - # Prefix the list here with "+" to use these queries and those in the config file. - # queries: ./path/to/local/query, your-org/your-repo/queries@main - - - run: npm ci - - run: npm run build - - run: rm -rf dist # We want code scanning to analyze lib instead (individual .js files) - - - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@v4 diff --git a/images/test-ubuntu-git.Dockerfile b/images/test-ubuntu-git.Dockerfile index c579327db..a34412a08 100644 --- a/images/test-ubuntu-git.Dockerfile +++ b/images/test-ubuntu-git.Dockerfile @@ -1,7 +1,7 @@ # Defines the test-ubuntu-git Container Image. # Consumed by actions/checkout CI/CD validation workflows. -FROM ubuntu:26.04@sha256:678c6550cc43645e08669028bc177f50be4e7c5b8cca677067b1914d4afc7a03 +FROM ubuntu:26.04 RUN apt update RUN apt install -y git