Skip to content
This repository was archived by the owner on May 4, 2023. It is now read-only.
This repository was archived by the owner on May 4, 2023. It is now read-only.

Examples: contourApproach depends on envSampling modifying NDBC46022.h5 #39

Description

@ssolson

example_contourApproach.py requires that example_envSampling.py has run and modified NDBC46022.h5.

This creates a required order to run the examples which is not clear to the intended audience (e.g. a new user). Further, while the user can specify the output H5 file name the duplication of the full buoy dataset does not seem ideal (e.g. the user now has 2 files of buoy data only differing by one having contour output from running example_envSampling.py). Finally, I believe this modification of the H5 file in place contributed to #29

I propose to address these issues and prevent future ones we:

  1. Remove any dependency between examples
  2. Restructure how we save contour data (e.g. I think we should look into having results separate from input)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions