Jenkins job is not being stopped when verigreen status is 'CANCELLED'

[aleitamar]

Jenkins job is not being stopped when verigreen status is 'CANCELLED'

When a parent commit fails, verigreen marks the child job as CANCELLED but it is still running in jenkins.
Shouldn't verigreen stop the cancelled jenkins job in such a case?

[soninob]

which Jenkins version are you using?

[aleitamar]

@soninob
2.89.3

[aleitamar]

@soninob FYI
Recently i setup verigreen dev env locally on my windows machine.
To bypass this issue and use java 1.8 i did the following:

1. changed spring version to 4.3.21.RELEASE both in the root pom.xml and in the vg-common pom.xml.
2. removed maven-javadoc-plugin from jenkins-client pom.xml

This did not reproduce using Jenkins 2.150.1

i did not test it in production (linux docker container) yet, but locally both the hook and the collector run successfully.

[soninob]

@aleitamar did you test it on linux docker container yet?
can you supply a PR for this? I would like to merge it

[aleitamar]

@soninob
Did not test on linux,
version 2.5.6 works fine on our linux (docker) env.
created pull request for java 1.8 support with the changes mentioned above
i'll be happy to test it if you can create a docker image for it
#134

[soninob]

@aleitamar - I'm trying to test your code from forked repo, seems that I can' bypass an exception of:
java.lang.NoClassDefFoundError: org/jboss/util/xml/JBossEntityResolver.
Did you encounter this problem?
can you supply a PR without this error?

[aleitamar]

Are you using java 8? When do you get this error? While running the server or git hook?

…

On Mon, Oct 28, 2019, 18:33 Barak Nisim Sonino ***@***.***> wrote: @aleitamar <https://github.com/aleitamar> - I'm trying to test your code from forked repo, seems that I can' bypass an exception of: java.lang.NoClassDefFoundError: org/jboss/util/xml/JBossEntityResolver. Did you encounter this problem? can you supply a PR without this error? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#133?email_source=notifications&email_token=AAXV4VDR5Y3LTMWHZLUEGQDQQ4H5VA5CNFSM4FCNBNB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECNQZHQ#issuecomment-547032222>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXV4VC3L4FJPIDC4JIP4XTQQ4H5VANCNFSM4FCNBNBQ> .

[soninob]

Running Jetty from verigreen-collector-webapp, using the command

mvn jetty:run

[ibenlays]

@soninob Works on my env using JDK 1.8

[soninob]

I'm also using JDK 1.8.
Can you share which maven version are you using?
what is you code base, VG origin master, or alteitamar's forked? master branch or test branch?
Here is the error I'm getting:
INFO: Loading XML bean definitions from ServletContext resource [/WEB-INF/applic ationContext.xml] ??? 29, 2019 8:10:00 AM org.springframework.web.context.ContextLoader initWebApp licationContext INFO: Root WebApplicationContext: initialization completed in 632 ms 2019-10-29 08:10:00.368:WARN:oejuc.AbstractLifeCycle:main: FAILED o.e.j.m.p.Jett yWebAppContext@2f6bcf87{/,file:/C:/verigreen-master_aleitamar/verigreen-collecto r-webapp/src/main/webapp/,STARTING}{file:/C:/verigreen-master_aleitamar/verigree n-collector-webapp/src/main/webapp/}: java.lang.NoClassDefFoundError: org/jboss/ util/xml/JBossEntityResolver java.lang.NoClassDefFoundError: org/jboss/util/xml/JBossEntityResolver at org.jboss.cache.config.parsing.RootElementBuilder.<clinit>(RootElemen tBuilder.java:51) at org.jboss.cache.config.parsing.XmlConfigurationParser.<init>(XmlConfi gurationParser.java:93) at org.jboss.cache.DefaultCacheFactory.createCache(DefaultCacheFactory.j ava:81) at com.verigreen.common.jbosscache.CacheInstance.start(CacheInstance.jav a:45) at com.verigreen.collector.core.ServerListener.contextInitialized(Server Listener.java:32) at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialize d(ContextHandler.java:800)

[aleitamar]

I tested with commit id 474434c
aleitamar/master branch
eclipse version 2019-09 R (4.13.0)
Maven that comes with eclipse 3.6.1