Scope credential secret pickers

Author: RhysSullivan

packages/plugins/openapi/src/react/AddOpenApiSource.tsx

@@ -946,7 +946,6 @@ export default function AddOpenApiSource(props: {
                 targetScope={sourceScope}
                 credentialScopeOptions={credentialScopeOptions}
                 bindingScopeOptions={credentialScopeOptions}
-                restrictSecretsToTargetScope
                 labels={{
                   headers: "Spec fetch headers",
                   queryParams: "Spec fetch query parameters",
@@ -1085,7 +1084,6 @@ export default function AddOpenApiSource(props: {
                   targetScope={sourceScope}
                   credentialScopeOptions={credentialScopeOptions}
                   bindingScopeOptions={credentialScopeOptions}
-                  restrictSecretsToTargetScope
                   emptyLabel="No credentials yet. Add the header value this method should use."
                 />
               </div>
@@ -1099,7 +1097,6 @@ export default function AddOpenApiSource(props: {
               targetScope={sourceScope}
               credentialScopeOptions={credentialScopeOptions}
               bindingScopeOptions={credentialScopeOptions}
-              restrictSecretsToTargetScope
               sections={{ headers: false, queryParams: true }}
               labels={{ queryParams: "Runtime query parameters" }}
             />

packages/react/src/plugins/headers-list.tsx

@@ -43,11 +43,10 @@ export interface HeadersListProps {
   readonly sourceName?: string;
   /** Inline-created secrets are written to this explicit scope. */
   readonly targetScope: ScopeId;
-  /** Scope choices shown only inside the inline "+ New secret" form. */
+  /** Scope choices available for where this source credential is used. */
   readonly credentialScopeOptions?: readonly CredentialTargetScopeOption[];
   /** Scope choices for where this source credential is used. */
   readonly bindingScopeOptions?: readonly CredentialTargetScopeOption[];
-  readonly restrictSecretsToTargetScope?: boolean;
   readonly defaultValueKind?: HeaderState["valueKind"];
 }
 
@@ -65,7 +64,6 @@ export function HeadersList({
   sourceName,
   targetScope,
   bindingScopeOptions,
-  restrictSecretsToTargetScope,
   defaultValueKind = "secret",
 }: HeadersListProps) {
   const [picking, setPicking] = useState(false);
@@ -153,7 +151,6 @@ export function HeadersList({
                 existingSecrets={existingSecrets}
                 sourceName={sourceName}
                 bindingScopeOptions={bindingScopeOptions}
-                restrictSecretsToTargetScope={restrictSecretsToTargetScope}
                 copy={rowCopy}
                 previewComponent={rowPreviewComponent}
               />
@@ -188,7 +185,6 @@ function HeaderRow(props: {
   readonly existingSecrets: readonly SecretPickerSecret[];
   readonly sourceName?: string;
   readonly bindingScopeOptions?: readonly CredentialTargetScopeOption[];
-  readonly restrictSecretsToTargetScope?: boolean;
   readonly copy?: Partial<SecretCredentialRowCopy>;
   readonly previewComponent?: SecretCredentialPreviewComponent;
 }) {
@@ -220,7 +216,6 @@ function HeaderRow(props: {
       sourceName={props.sourceName}
       targetScope={props.header.targetScope ?? props.targetScope}
       bindingScopeOptions={props.bindingScopeOptions}
-      restrictSecretsToTargetScope={props.restrictSecretsToTargetScope}
       copy={props.copy}
       previewComponent={props.previewComponent}
     />

packages/react/src/plugins/http-credentials.tsx

@@ -287,7 +287,6 @@ export function HttpCredentialsEditor(props: {
   readonly targetScope: ScopeId;
   readonly credentialScopeOptions?: readonly CredentialTargetScopeOption[];
   readonly bindingScopeOptions?: readonly CredentialTargetScopeOption[];
-  readonly restrictSecretsToTargetScope?: boolean;
   readonly sections?: {
     readonly headers?: boolean;
     readonly queryParams?: boolean;
@@ -314,7 +313,6 @@ export function HttpCredentialsEditor(props: {
             targetScope={props.targetScope}
             credentialScopeOptions={props.credentialScopeOptions}
             bindingScopeOptions={props.bindingScopeOptions}
-            restrictSecretsToTargetScope={props.restrictSecretsToTargetScope}
             presets={props.headerPresets}
           />
         </section>
@@ -331,7 +329,6 @@ export function HttpCredentialsEditor(props: {
             targetScope={props.targetScope}
             credentialScopeOptions={props.credentialScopeOptions}
             bindingScopeOptions={props.bindingScopeOptions}
-            restrictSecretsToTargetScope={props.restrictSecretsToTargetScope}
             presets={queryParamPresets}
             emptyLabel="No query parameters"
             addLabel="Add query parameter"

packages/react/src/plugins/secret-header-auth.tsx

@@ -314,7 +314,6 @@ export function SecretHeaderAuthRow(props: {
   sourceName?: string;
   targetScope: ScopeId;
   bindingScopeOptions?: readonly CredentialTargetScopeOption[];
-  restrictSecretsToTargetScope?: boolean;
 }) {
   const [creating, setCreating] = useState(false);
   const nameInputId = useId();
@@ -335,15 +334,13 @@ export function SecretHeaderAuthRow(props: {
     sourceName,
     targetScope,
     bindingScopeOptions,
-    restrictSecretsToTargetScope = false,
   } = props;
 
   const isCustom = presetKey === "custom" || presetKey === undefined;
   const copy = { ...defaultSecretCredentialRowCopy, ...copyOverride };
   const headerLabel = name.trim() || "Custom Header";
   const suggestedName = [sourceName?.trim(), headerLabel].filter(Boolean).join(" ");
   const scopedSecrets = secretsForCredentialTarget(existingSecrets, targetScope);
-  const selectableSecrets = restrictSecretsToTargetScope ? scopedSecrets : existingSecrets;
 
   return (
     <div className="space-y-2.5 px-4 py-3">
@@ -426,7 +423,7 @@ export function SecretHeaderAuthRow(props: {
             value={secretId}
             valueScopeId={secretScope ? String(secretScope) : undefined}
             onSelect={(id, scopeId) => onSelectSecret(id, ScopeId.make(scopeId))}
-            secrets={selectableSecrets}
+            secrets={scopedSecrets}
             onCreateNew={() => setCreating(true)}
           />
         </div>
@@ -528,7 +525,7 @@ export function CreatableSecretPicker(props: {
       value={value}
       valueScopeId={String(targetScope)}
       onSelect={(id, scopeId) => onSelect(id, ScopeId.make(scopeId))}
-      secrets={secrets}
+      secrets={scopedSecrets}
       placeholder={placeholder}
       onCreateNew={() => setCreating(true)}
     />