[codex] fix MCP output schema contracts #2005
RhysSullivanci.yml
on: pull_request
Format
2m 16s
Lint
2m 5s
Typecheck
2m 49s
Test
1m 37s
Desktop smoke build
2m 42s
Annotations
6 errors and 5 warnings
|
Format
Process completed with exit code 1.
|
|
Test
Process completed with exit code 1.
|
|
Test
@executor-js/plugin-mcp#test: command (/home/runner/work/executor/executor/packages/plugins/mcp) /home/runner/.bun/bin/bun run test exited (1)
|
|
src/sdk/elicitation.test.ts > MCP elicitation (end-to-end) > refreshSource keeps MCP outputSchema nested under structuredContent:
packages/plugins/mcp/src/sdk/elicitation.test.ts#L244
AssertionError: expected { type: 'object', …(4) } to match object { type: 'object', …(2) }
(6 matching properties omitted from actual)
- Expected
+ Received
{
"properties": {
- "content": {
- "type": "array",
- },
- "structuredContent": {
- "properties": {
"upper": {
"type": "string",
},
"value": {
"type": "string",
- },
- },
- "type": "object",
},
},
"required": [
- "content",
- "structuredContent",
+ "value",
+ "upper",
],
"type": "object",
}
❯ Array.<anonymous> src/sdk/elicitation.test.ts:244:36
❯ next ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:1276:25
❯ Object.~effect/Effect/evaluate ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/core.ts:531:30
❯ FiberImpl.runLoop ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:633:39
❯ runLoop ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:593:22
❯ evaluate ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:1030:14
|
|
src/sdk/elicitation.test.ts > MCP elicitation (end-to-end) > successful tool invocation preserves structured MCP result fields:
packages/plugins/mcp/src/sdk/elicitation.test.ts#L187
AssertionError: expected { type: 'object', …(4) } to match object { type: 'object', …(2) }
(6 matching properties omitted from actual)
- Expected
+ Received
{
"properties": {
- "_meta": {
- "type": "object",
- },
- "content": {
- "type": "array",
- },
- "structuredContent": {
- "properties": {
"upper": {
"type": "string",
},
"value": {
"type": "string",
},
},
- "type": "object",
- },
- },
"required": [
- "content",
- "structuredContent",
+ "value",
+ "upper",
],
"type": "object",
}
❯ Array.<anonymous> src/sdk/elicitation.test.ts:187:36
❯ next ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:1276:25
❯ Object.~effect/Effect/evaluate ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/core.ts:531:30
❯ FiberImpl.runLoop ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:633:39
❯ runLoop ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:593:22
❯ evaluate ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:1030:14
|
|
src/sdk/elicitation.test.ts > MCP elicitation (end-to-end) > registered tools without MCP outputSchema still describe CallToolResult:
packages/plugins/mcp/src/sdk/elicitation.test.ts#L154
AssertionError: expected undefined to match object { type: 'object', …(2) }
- Expected:
{
"properties": {
"_meta": {
"type": "object",
},
"content": {
"type": "array",
},
"isError": {
"const": false,
},
"structuredContent": {},
},
"required": [
"content",
],
"type": "object",
}
+ Received:
undefined
❯ Array.<anonymous> src/sdk/elicitation.test.ts:154:36
❯ next ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:1276:25
❯ Object.~effect/Effect/evaluate ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/core.ts:531:30
❯ FiberImpl.runLoop ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:633:39
❯ runLoop ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:593:22
❯ evaluate ../../../node_modules/.bun/effect@4.0.0-beta.59/node_modules/effect/src/internal/effect.ts:1030:14
|
|
Lint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Format
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Desktop smoke build
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Typecheck
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|