ticklen will reset labels when labels = "both" are given

[cvanelteren]

This might be the same bug, so I posted here.

import ultraplot as pplt
print("Ultraplot version:", pplt.__version__)
fig,ax=pplt.subplot(proj='cyl')
ax.format(labels='both', ticklen=.5)

Set ticklen override labels='both'.

Originally posted by @gepcel in #518 (comment)

[gepcel]

As I mentioned, issue came back again, pr might be reverted.

Originally posted by @gepcel in #518 (comment)

[cvanelteren]

Are you on main?

On main I get this:

[cvanelteren]

import ultraplot as pplt

print("Ultraplot version:", pplt.__version__)
fig, ax = pplt.subplot(proj="cyl")
ax.format(labels="both", ticklen=5)

[gepcel]

I'm assumming I'm on main, I pulled from upstream main this morning. Can you tell from the version info? Haven't figure out that dev68+ga081e9f65 means.

[cvanelteren]

The dev stuff just means are running the git version, maybe you have 2 seperate versions installed (happens sometimes).

[gepcel]

Ok, let me delete all and start over and test on main.

[cvanelteren]

after you delete you can just install with pip -e . and never touch it again -- that's at least what I do.

[gepcel]

after you delete you can just install with pip -e . and never touch it again -- that's at least what I do.

For ultraplot, I use pip install -e . all the time. May be some branch, pull, mereg, rebase, messed up.

Update: I pip removed ultraplot, delete ultraplot folder completed on local pc, delete focked repo on github, focked again, git clone again, and git pull upstream again, pip install -e . again. Result as:

[gepcel]

The reason I go back and test this today is I noticed you added lines in pr #520 first, and deleted in pr #518 later, which I couldn't understand.

            # Avoid overriding gridliner label toggles via tick_params defaults.
            for key in ("labeltop", "labelbottom", "labelleft", "labelright"):
                params.pop(key, None)

[cvanelteren]

You are right not sure what happened there -- re-added the lines.