Skip to content

The code doesnt work when not specifying the correct quant params #23

@leonl42

Description

@leonl42

In line 198 in train_kmeans.py:

kmeans_dict = {'rot': kmeans_rot_q, 'scale': kmeans_sc_q, 'sh': kmeans_sh_q, 'dc': kmeans_dc_q}

The problem with this line is that it accesses variables that are never defined if a key, e.g. 'rot', is not in the quantized params argparse argument. Additionally, if I'm not mistaken, the code in this state does not allow saving quantized params other than those defined in kmeans_dict?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions