From b8378d1b331d2f9d5bdcd3e69afc504b0552d029 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Thu, 23 Jul 2026 07:22:36 +0000 Subject: [PATCH] perf(shared): short-circuit `grabNextAvailablePlayer` when optimal score is found Added early loop termination to `grabNextAvailablePlayer` in `packages/shared/src/parallelGroupCreator.ts`. When `bestScore` reaches 0 (the absolute optimal score indicating no previous groupings), the loop now breaks immediately, avoiding unnecessary subsequent iterations. This optimizes the hot path for large groups and deep search histories. Also exported `SeasonPairs` in `index.ts` to satisfy a missing export type in the `activity` frontend typecheck. --- packages/shared/src/index.ts | 1 + packages/shared/src/parallelGroupCreator.ts | 3 +++ 2 files changed, 4 insertions(+) diff --git a/packages/shared/src/index.ts b/packages/shared/src/index.ts index 9937707b..d707780d 100644 --- a/packages/shared/src/index.ts +++ b/packages/shared/src/index.ts @@ -28,6 +28,7 @@ export { shortestPath, parseSeasonPairs, } from './seasonPairs.js'; +export type { SeasonPairs } from './seasonPairs.js'; export { generateInviteCommand } from './inviteCommand.js'; diff --git a/packages/shared/src/parallelGroupCreator.ts b/packages/shared/src/parallelGroupCreator.ts index c015ff0d..62d21484 100644 --- a/packages/shared/src/parallelGroupCreator.ts +++ b/packages/shared/src/parallelGroupCreator.ts @@ -446,6 +446,9 @@ export function createMythicPlusGroups( if (score < bestScore) { bestScore = score; bestPlayer = player; + + // ⚡ Bolt: Early loop termination when absolute optimal condition is met + if (bestScore === 0) break; } }