🛡️ Sentinel: [CRITICAL] Fix Path Traversal in Battle.net API Client#597
🛡️ Sentinel: [CRITICAL] Fix Path Traversal in Battle.net API Client#597google-labs-jules[bot] wants to merge 1 commit into
Conversation
This commit URL-encodes the `realmSlug` and `characterName` variables when constructing paths for the Battle.net API in `getCharacterProfile`, `getCharacterMedia`, and `getCharacterSpecializations`. Because these values are sometimes populated from the `preferences` Firestore collection, which clients have write access to, a malicious user could insert path traversal sequences (e.g. `../`) and trigger SSRF vulnerabilities or manipulate backend API requests. Applying `encodeURIComponent` mitigates this risk.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Severity: CRITICAL
Vulnerability: Path traversal / SSRF risk in the Battle.net API client (
packages/functions/src/battlenet.ts).Impact: A malicious user could write to their
preferencesdocument in Firestore (which is client-writable perfirestore.rules) and include path traversal characters (like../) in their character name or realm slug. The backend scheduled jobs or callables reading this would interpolate it directly into a Battle.net API URL, leading to potential Server-Side Request Forgery or unintended API manipulation.Fix: Modified
packages/functions/src/battlenet.tsto URL-encode (encodeURIComponent) therealmSlugandcharacterNamewhen constructing the paths forgetCharacterProfile,getCharacterMedia, andgetCharacterSpecializations.Verification: Verified via
git diffthat encoding was correctly applied to all path segments. Ran the backend tests via./scripts/verify-ts.sh, ensuring that no functionality was broken. All tests passed successfully. The learning was properly journaled in.jules/sentinel.md.PR created automatically by Jules for task 11342748481366269047 started by @TytaniumDev