From 38ba753084298be8f3aeba6a011a06ff233296e6 Mon Sep 17 00:00:00 2001 From: Alexander Ronald Altman Date: Thu, 25 Nov 2021 21:33:07 -0800 Subject: [PATCH 1/2] The PR checker should check DeveloperFixed Notes Previously this wasn't happening, as visible in #294. --- format_checker/pr_checker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/format_checker/pr_checker.py b/format_checker/pr_checker.py index 4f3be9339..cdd71addb 100644 --- a/format_checker/pr_checker.py +++ b/format_checker/pr_checker.py @@ -91,7 +91,7 @@ def check_status_consistency(filename, row, i, log): else: check_pr_link(filename, row, i, log) - if row["Status"] in ["InspiredAFix", "Skipped", "MovedOrRenamed"]: + if row["Status"] in ["InspiredAFix", "Skipped", "MovedOrRenamed", "DeveloperFixed"]: # Should contain a note if row["Notes"] == "": From 67a047927fc32a20b999dfc18112294b7e8e9a13 Mon Sep 17 00:00:00 2001 From: Alexander Ronald Altman Date: Thu, 25 Nov 2021 21:47:37 -0800 Subject: [PATCH 2/2] PR Checker should check PR Link for DeveloperFixed --- format_checker/pr_checker.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/format_checker/pr_checker.py b/format_checker/pr_checker.py index cdd71addb..8e6437762 100644 --- a/format_checker/pr_checker.py +++ b/format_checker/pr_checker.py @@ -118,6 +118,11 @@ def check_status_consistency(filename, row, i, log): else: check_pr_link(filename, row, i, log) + if row["Status"] == "DeveloperFixed": + # Should contain either no PR Link or a valid one + if not row["PR Link"] == "": + check_pr_link(filename, row, i, log) + if row["Status"] == "" and row["PR Link"] != "": check_pr_link(filename, row, i, log) log_std_error(filename, log, i, row, "Status should not be empty when a PR link is provided.")