diff --git a/format_checker/pr_checker.py b/format_checker/pr_checker.py index 4f3be9339..8e6437762 100644 --- a/format_checker/pr_checker.py +++ b/format_checker/pr_checker.py @@ -91,7 +91,7 @@ def check_status_consistency(filename, row, i, log): else: check_pr_link(filename, row, i, log) - if row["Status"] in ["InspiredAFix", "Skipped", "MovedOrRenamed"]: + if row["Status"] in ["InspiredAFix", "Skipped", "MovedOrRenamed", "DeveloperFixed"]: # Should contain a note if row["Notes"] == "": @@ -118,6 +118,11 @@ def check_status_consistency(filename, row, i, log): else: check_pr_link(filename, row, i, log) + if row["Status"] == "DeveloperFixed": + # Should contain either no PR Link or a valid one + if not row["PR Link"] == "": + check_pr_link(filename, row, i, log) + if row["Status"] == "" and row["PR Link"] != "": check_pr_link(filename, row, i, log) log_std_error(filename, log, i, row, "Status should not be empty when a PR link is provided.")