Stabilize logger-based unit tests by enabling fake ILogger in affected suites#1318
Open
Copilot wants to merge 9 commits into
Open
Stabilize logger-based unit tests by enabling fake ILogger in affected suites#1318Copilot wants to merge 9 commits into
ILogger in affected suites#1318Copilot wants to merge 9 commits into
Conversation
Copilot created this pull request from a session on behalf of
SebastianStehle
May 26, 2026 16:05
View session
Copilot stopped work on behalf of
SebastianStehle due to an error
May 26, 2026 16:13
Copilot
AI
changed the title
Use source-generated logging in core backend paths
Centralize source-generated logging into project-level LogMessages classes (remove EventIds)
May 26, 2026
Copilot
AI
changed the title
Centralize source-generated logging into project-level LogMessages classes (remove EventIds)
Centralize backend logging messages per project and remove EventId usage
May 26, 2026
Copilot
AI
changed the title
Centralize backend logging messages per project and remove EventId usage
Centralize Infrastructure/Web ILogger messages into project LogMessages classes (remove EventIds)
May 26, 2026
Copilot
AI
changed the title
Centralize Infrastructure/Web ILogger messages into project LogMessages classes (remove EventIds)
Extend [LoggerMessage] source generation to all projects using ILogger
May 26, 2026
Copilot
AI
changed the title
Extend [LoggerMessage] source generation to all projects using ILogger
Align MigratorTests with ILogger IsEnabled gating
May 26, 2026
Copilot
AI
changed the title
Align MigratorTests with ILogger IsEnabled gating
Stabilize logger-based unit tests by enabling fake May 27, 2026
ILogger in affected suites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent test failures were caused by log assertions expecting
ILogger.Log(...)calls that never fired. The suites were exercisingLoggerMessage-generated logging paths, which now gate emission behindILogger.IsEnabled(...).Root cause addressed
IsEnabledbehavior.IsEnabled(level)was invoked and log assertions failed.Test setup updates
MigratorTestsInvitationEventConsumerTestsEmailUserNotificationsTestsBehavioral impact