Skip to content

Add missing basis functions #64

Description

@danielward27

I believe currently missing are:

  1. smooth.construct.ad.smooth.spec - Adaptive smooths
  2. smooth.construct.gp.smooth.spec - Gaussian process smooths
  3. smooth.construct.so.smooth.spec - Soap film smooths
  4. smooth.construct.sz.smooth.spec - Sum to zero smooth interactions

They should be added to basis_functions.py, and test cases probably added to spline_test_cases in gam_test_cases.py. spline_test_cases should be renamed to be something like basis_function_test_cases and ideally include a case for each basis at least.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions