refactor: Update Docker image handling and registry configuration#321
Merged
Conversation
- Modified `services.py` to support prebuilt images from GHCR and custom registries, enhancing flexibility in image management. - Updated `pull-images.sh` and `push-images.sh` scripts to streamline image pulling and pushing processes, allowing for backward compatibility with DockerHub. - Refactored Docker Compose configurations to align with new image naming conventions, ensuring consistency across services. - Enhanced error messages and documentation for improved clarity on registry usage and image management.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrates the Docker image ecosystem from a DockerHub-centric approach to GHCR (GitHub Container Registry) as the default, while keeping backward compatibility with DockerHub and supporting arbitrary custom registries.
Image Name Standardization
All images renamed to a consistent
chronicle-*prefix:advanced-chronicle-backendchronicle-backendadvanced-workersadvanced-webuichronicle-webuiparakeet-asr-{cuda}chronicle-asr-nemo-{cuda}speaker-recognition-{cuda}chronicle-speaker-{cuda}openmemory-mcpRegistry Precedence (3-tier)
All scripts and
services.pynow share the same precedence logic:CHRONICLE_REGISTRYDOCKERHUB_USERNAMEghcr.io/simpleopensoftware/Changes Per File
1.
.github/workflows/advanced-docker-compose-build.ymlchronicle-*prefixopenmemory-mcpfrom build matrix and path triggersworkersimage (now shares backend image)2.
scripts/pull-images.shDOCKERHUB_USERNAME— defaults to public GHCR./scripts/pull-images.sh v1.0.0works without any env varsCHRONICLE_REGISTRYsupport for custom registries3.
scripts/push-images.shCHRONICLE_PUSH_REGISTRYenv var for explicit push targetDOCKERHUB_USERNAMEfor backward compatCHRONICLE_REGISTRY=4.
services.py--use-prebuiltno longer requiresDOCKERHUB_USERNAME./start.sh --use-prebuilt v1.0.0works out of the box