Skip to content

Possible Fix : Connected flag in NIOHandler.java > openOutgoingConnection is not updated correctly #188

Description

@adkhadilkar

First thanks for making this great library for SIP communication !!

While using the Jain SIP library for SIP over Websocket, I found one issue in NIOHandler.java file in openOutgoingConnection method. Inside the openOutgoingConnection there is connected flag (Line 257) defined which wasn't updated in the same method. As we are checking the value in finally(Line 369/371) everytime it is creating new socket.

Ideally from my understanding we need to set the connected to true once we create the socket. before/after putSocket(key, clientSock); line (305/356)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions