Route post-merge NewRegistration to the registration form instead of register/wallet#711
Closed
TaprootFreak wants to merge 1 commit into
Closed
Route post-merge NewRegistration to the registration form instead of register/wallet#711TaprootFreak wants to merge 1 commit into
TaprootFreak wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by the cleaner, CONTRIBUTING-aligned design (Option 2): the email-verification step now only confirms the merge and delegates ALL registration routing to KycCubit (single source of truth), instead of branching inline. See the replacement PR. |
4 tasks
TaprootFreak
added a commit
that referenced
this pull request
Jun 9, 2026
## Summary
Fixes the post-account-merge "Wallet registration not complete" error
(red banner) in the RealUnit app, the CONTRIBUTING-aligned way.
When a new wallet signs up with an email that already belongs to an
existing **DFX** account (account merge) and that account has **no prior
RealUnit registration**, `GET /v1/realunit/registration` returns
`state=NewRegistration`. The email-verification step, however, called
`registerWallet` (`POST /register/wallet`) **unconditionally** — that
endpoint only *adds* a wallet to an **existing** registration, so the
API returns `400 "No RealUnit registration found"`.
## Root cause — runtime-confirmed (PROD App Insights)
- `GET /v1/realunit/registration` → **200** (state=NewRegistration,
userData present from existing KYC)
- `POST /v1/realunit/register/wallet` → **400 `{"message":"No RealUnit
registration found"}`** (×4 retries)
- recovery: the user reached the KYC registration form → `POST
/v1/realunit/register/complete` → **201**
- DB: the merged account had no `RealUnitRegistration` step until
`register/complete` created it. 7-day breadth: 7× this 400 (affects
every merge into a DFX account without a prior RealUnit registration).
## Fix (app-only) — single source of registration routing
The email-verification flow is reduced to its actual job: **confirm the
merge** (detect the JWT account change) and hand back to the KYC flow.
`KycCubit` is now the only place that interprets the registration
`state` and routes it (addWallet → link wallet, NewRegistration → full
registration form, AlreadyRegistered → forward) — per CONTRIBUTING.md
"API as Decision Authority". This removes the duplicated, unconditional
`register/wallet` call.
Dead code removed accordingly: `_completeRegistration`,
`_mergeDetected`, the `RealUnitRegistrationService` dependency, the
`KycEmailVerificationRegistrationFailure` state, and the now-unused i18n
key `registerEmailVerificationRegistrationFailed` (de + en).
## Tests
- email cubit (simplified): same account → Failure (link not visited);
changed account → Success (merge confirmed; no registration here); retry
(Failure → Success).
- `kyc_step_states_test` updated for the removed state.
## Test plan
- [x] `flutter analyze` clean
- [x] `flutter test --exclude-tags golden` — full suite passes (2312)
- [x] Coverage Floor Gate replicated locally — scoped **lines 100.0%**
(floor 100)
- [ ] DEV end-to-end: merge into a DFX account without RealUnit
registration → no red error → lands on the registration form →
register/complete
Supersedes #711 (minimal variant) and the earlier incorrect
MergeProcessing PRs DFXswiss/api#3848 + #709.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the real cause of the post-account-merge "Wallet registration not complete" error in the RealUnit app.
When a new wallet signs up with an email that already belongs to an existing DFX account (account merge), and that account has no prior RealUnit/Aktionariat registration,
GET /v1/realunit/registrationcorrectly returnsstate = NewRegistration. The email-verification flow, however, calledregisterWallet(POST /v1/realunit/register/wallet) unconditionally — and that endpoint only adds a wallet to an existing registration, so the API rejects it with400 "No RealUnit registration found". The user sees a red error even though the merge succeeded.Root cause — runtime-confirmed (PROD)
App Insights for the reported incident:
GET /v1/realunit/registration→ 200 (state=NewRegistration, userData present from existing KYC)POST /v1/realunit/register/wallet→ 400{"message":"No RealUnit registration found"}(×4 retries)POST /v1/realunit/register/complete→ 201DB confirmed the merged account had no
RealUnitRegistrationstep untilregister/completecreated it. 7-day breadth: 7×register/wallet400 with this message (64% of register/wallet calls) — affects every merge into a DFX account without a prior RealUnit registration.Fix (app-only, no API change)
KycEmailVerificationCubit._completeRegistration: whenstate == newRegistration, do not callregisterWallet. The merge is already confirmed (JWT account changed), so hand back to the KYC flow —KycCubitroutesNewRegistrationto the full registration form (register/complete), exactly as the main KYC flow already does for that state (and as the runtime recovery proved works).addWallet/alreadyRegisteredkeep the existing inlineregisterWallet.Tests
newRegistration(null userData) → Success/handoff, noregisterWalletnewRegistrationWITH userData present → Success/handoff, noregisterWallet(reproduces the real bug: KYC firstname makes userData non-null)addWallet→ still callsregisterWallet(unchanged)_mergeDetectedretry test (transientregisterWalletfailure on AddWallet → retry → Success)Test plan
flutter analyzecleanflutter test --exclude-tags golden— 2315 tests pass (full suite)Replaces the earlier (incorrect) MergeProcessing PRs DFXswiss/api#3848 and #709, which addressed a propagation race that the runtime data showed never occurred.